appengine/findit/waterfall/try_job_enums.py - Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/waterfall/try_job_enums.py

Issue 1591003002: [Findit] Modify tryjob pipelines to trigger try jobs for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py ('K') | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | appengine/findit/waterfall/try_job_pipeline.py » ('j') | appengine/findit/waterfall/try_job_result_format.md » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #!/usr/bin/env python

2 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	3 # found in the LICENSE file.

5	4

6 import sys

7	5

8 from infra.tools.cq_stats import cq_stats	6 class TryJobType():

	7 type_compile = 'compile'
	stgao 2016/01/28 19:33:52 IIRC, constant usually use upper-case instead of l IIRC, constant usually use upper-case instead of lower-case for var names. chanli 2016/01/28 22:40:12 Done. Show quoted text On 2016/01/28 19:33:52, stgao wrote: > IIRC, constant usually use upper-case instead of lower-case for var names. Done.
	8 type_test = 'test'
	stgao 2016/01/28 19:33:52 It seems the 'type' in the var name is a bit redun It seems the 'type' in the var name is a bit redundant, as the enum class name already indicates that. chanli 2016/01/28 22:40:12 Done. Show quoted text On 2016/01/28 19:33:52, stgao wrote: > It seems the 'type' in the var name is a bit redundant, as the enum class name > already indicates that. Done.
9	9

10	10

11 if __name__ == '__main__':	11 class TryJobStatus():
	stgao 2016/01/28 19:33:52 It seems duplicating common.buildbucket_client.Bui It seems duplicating common.buildbucket_client.BuildbucketBuild chanli 2016/01/28 22:40:12 Done. Show quoted text On 2016/01/28 19:33:52, stgao wrote: > It seems duplicating common.buildbucket_client.BuildbucketBuild Done.
12 sys.exit(cq_stats.main())	12 scheduled = 'SCHEDULED'

	13 started = 'STARTED'

	14 completed = 'COMPLETED'

OLD	NEW