Chromium Code Reviews

Issue 1590963002: Switch GetConcurrentlyOptimizedCode to MaybeHandle. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-18
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switch GetConcurrentlyOptimizedCode to MaybeHandle. The function in question can already return an empty handle in the case of failures. This makes that contract explicit by using MaybeHandle like all other compiler API functions. R=yangguo@chromium.org Committed: https://crrev.com/b881c908a18e3bf6f3cb73d91c1b5a063aa511f3 Cr-Commit-Position: refs/heads/master@{#33839}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Stats (+14 lines, -10 lines)
M src/compiler.h View 1 chunk +2 lines, -1 line 0 comments
M src/compiler.cc View 2 chunks +3 lines, -3 lines 0 comments
M src/optimizing-compile-dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments
M src/runtime/runtime-compiler.cc View 3 chunks +7 lines, -4 lines 0 comments

Messages

Total messages: 12 (5 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-15 14:50:49 UTC) #1
Yang
On 2016/01/15 14:50:49, Michael Starzinger wrote: lgtm.
4 years, 11 months ago (2016-01-19 10:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590963002/1
4 years, 11 months ago (2016-01-19 10:22:27 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/11048)
4 years, 11 months ago (2016-01-19 10:37:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590963002/40001
4 years, 10 months ago (2016-02-09 09:46:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-09 09:47:44 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 09:48:11 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b881c908a18e3bf6f3cb73d91c1b5a063aa511f3
Cr-Commit-Position: refs/heads/master@{#33839}

Powered by Google App Engine