Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: src/compiler.h

Issue 1590963002: Switch GetConcurrentlyOptimizedCode to MaybeHandle. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-18
Patch Set: Fix typo. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_H_ 5 #ifndef V8_COMPILER_H_
6 #define V8_COMPILER_H_ 6 #define V8_COMPILER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/bailout-reason.h" 10 #include "src/bailout-reason.h"
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 // Generate and return optimized code or start a concurrent optimization job. 630 // Generate and return optimized code or start a concurrent optimization job.
631 // In the latter case, return the InOptimizationQueue builtin. On failure, 631 // In the latter case, return the InOptimizationQueue builtin. On failure,
632 // return the empty handle. 632 // return the empty handle.
633 MUST_USE_RESULT static MaybeHandle<Code> GetOptimizedCode( 633 MUST_USE_RESULT static MaybeHandle<Code> GetOptimizedCode(
634 Handle<JSFunction> function, ConcurrencyMode mode, 634 Handle<JSFunction> function, ConcurrencyMode mode,
635 BailoutId osr_ast_id = BailoutId::None(), 635 BailoutId osr_ast_id = BailoutId::None(),
636 JavaScriptFrame* osr_frame = nullptr); 636 JavaScriptFrame* osr_frame = nullptr);
637 637
638 // Generate and return code from previously queued optimization job. 638 // Generate and return code from previously queued optimization job.
639 // On failure, return the empty handle. 639 // On failure, return the empty handle.
640 static Handle<Code> GetConcurrentlyOptimizedCode(OptimizedCompileJob* job); 640 MUST_USE_RESULT static MaybeHandle<Code> GetConcurrentlyOptimizedCode(
641 OptimizedCompileJob* job);
641 }; 642 };
642 643
643 644
644 class CompilationPhase BASE_EMBEDDED { 645 class CompilationPhase BASE_EMBEDDED {
645 public: 646 public:
646 CompilationPhase(const char* name, CompilationInfo* info); 647 CompilationPhase(const char* name, CompilationInfo* info);
647 ~CompilationPhase(); 648 ~CompilationPhase();
648 649
649 protected: 650 protected:
650 bool ShouldProduceTraceOutput() const; 651 bool ShouldProduceTraceOutput() const;
(...skipping 10 matching lines...) Expand all
661 size_t info_zone_start_allocation_size_; 662 size_t info_zone_start_allocation_size_;
662 base::ElapsedTimer timer_; 663 base::ElapsedTimer timer_;
663 664
664 DISALLOW_COPY_AND_ASSIGN(CompilationPhase); 665 DISALLOW_COPY_AND_ASSIGN(CompilationPhase);
665 }; 666 };
666 667
667 } // namespace internal 668 } // namespace internal
668 } // namespace v8 669 } // namespace v8
669 670
670 #endif // V8_COMPILER_H_ 671 #endif // V8_COMPILER_H_
OLDNEW
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698