Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1590873003: Value::IsObject should return true for proxies as well (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Value::IsObject should return true for proxies as well Because in the C++ API, a Proxy is an Object BUG=none R=bmeurer@chromium.org LOG=n CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng Committed: https://crrev.com/cccb7e1f58f9b257e4fd57a78f1487d03ef247b2 Cr-Commit-Position: refs/heads/master@{#33329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/api.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-15 12:08:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590873003/1
4 years, 11 months ago (2016-01-15 12:09:55 UTC) #3
jochen (gone - plz use gerrit)
ptal
4 years, 11 months ago (2016-01-15 12:10:08 UTC) #4
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-15 12:25:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590873003/1
4 years, 11 months ago (2016-01-15 12:28:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 13:06:25 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 13:07:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cccb7e1f58f9b257e4fd57a78f1487d03ef247b2
Cr-Commit-Position: refs/heads/master@{#33329}

Powered by Google App Engine
This is Rietveld 408576698