src/api.cc - Issue 1590873003: Value::IsObject should return true for proxies as well

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1590873003: Value::IsObject should return true for proxies as well (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index bfd17dbb8dc877da56891f1ee5c89cc1688b3ea8..acc9c82d3ecf40d9eeed6eb0d0d4d9ee233a3b33 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -2768,9 +2768,7 @@ bool Value::IsSharedArrayBuffer() const {

}

-bool Value::IsObject() const {

- return Utils::OpenHandle(this)->IsJSObject();

+bool Value::IsObject() const { return Utils::OpenHandle(this)->IsJSReceiver(); }

bool Value::IsNumber() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »