Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 1590873002: Make generators non-constructable. (Closed)

Created:
4 years, 11 months ago by neis
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make generators non-constructable. BUG=v8:4163, v8:4630 LOG=y R=rossberg Committed: https://crrev.com/faf5e6816933822b13e17cf358ef32ef15fbd192 Cr-Commit-Position: refs/heads/master@{#33360}

Patch Set 1 #

Patch Set 2 : Adapt test262.status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -54 lines) Patch
M src/api-natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 9 chunks +9 lines, -6 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M test/mjsunit/es6/generators-iteration.js View 2 chunks +3 lines, -15 lines 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +3 lines, -9 lines 0 comments Download
M test/mjsunit/es6/object-literals-method.js View 1 chunk +2 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
neis
4 years, 11 months ago (2016-01-15 10:34:46 UTC) #1
neis
This is based on issue 1530213002 (https://codereview.chromium.org/1530213002/). I address my comments there and removed some ...
4 years, 11 months ago (2016-01-15 10:39:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590873002/1
4 years, 11 months ago (2016-01-15 10:39:28 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/14011)
4 years, 11 months ago (2016-01-15 10:57:13 UTC) #8
rossberg
LGTM, minus the buildbot failures :)
4 years, 11 months ago (2016-01-15 12:54:10 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590873002/20001
4 years, 11 months ago (2016-01-15 13:25:47 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 13:49:23 UTC) #14
adamk
On 2016/01/15 10:39:04, neis wrote: > This is based on issue 1530213002 (https://codereview.chromium.org/1530213002/). > I ...
4 years, 11 months ago (2016-01-15 18:45:55 UTC) #15
rossberg
On 2016/01/15 18:45:55, adamk wrote: > As long as this lands after the M49 branch ...
4 years, 11 months ago (2016-01-18 08:45:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590873002/20001
4 years, 11 months ago (2016-01-18 12:39:30 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-18 13:10:43 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 13:11:14 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faf5e6816933822b13e17cf358ef32ef15fbd192
Cr-Commit-Position: refs/heads/master@{#33360}

Powered by Google App Engine
This is Rietveld 408576698