Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/runtime/runtime-generator.cc

Issue 1590873002: Make generators non-constructable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Adapt test262.status Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/mjsunit/es6/generators-iteration.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/factory.h" 8 #include "src/factory.h"
9 #include "src/frames-inl.h" 9 #include "src/frames-inl.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) { 15 RUNTIME_FUNCTION(Runtime_CreateJSGeneratorObject) {
16 HandleScope scope(isolate); 16 HandleScope scope(isolate);
17 DCHECK(args.length() == 0); 17 DCHECK(args.length() == 0);
18 18
19 JavaScriptFrameIterator it(isolate); 19 JavaScriptFrameIterator it(isolate);
20 JavaScriptFrame* frame = it.frame(); 20 JavaScriptFrame* frame = it.frame();
21 Handle<JSFunction> function(frame->function()); 21 Handle<JSFunction> function(frame->function());
22 RUNTIME_ASSERT(function->shared()->is_generator()); 22 RUNTIME_ASSERT(function->shared()->is_generator());
23 23
24 Handle<JSGeneratorObject> generator; 24 Handle<JSGeneratorObject> generator;
25 if (frame->IsConstructor()) { 25 DCHECK(!frame->IsConstructor());
26 generator = handle(JSGeneratorObject::cast(frame->receiver())); 26 generator = isolate->factory()->NewJSGeneratorObject(function);
27 } else {
28 generator = isolate->factory()->NewJSGeneratorObject(function);
29 }
30 generator->set_function(*function); 27 generator->set_function(*function);
31 generator->set_context(Context::cast(frame->context())); 28 generator->set_context(Context::cast(frame->context()));
32 generator->set_receiver(frame->receiver()); 29 generator->set_receiver(frame->receiver());
33 generator->set_continuation(0); 30 generator->set_continuation(0);
34 generator->set_operand_stack(isolate->heap()->empty_fixed_array()); 31 generator->set_operand_stack(isolate->heap()->empty_fixed_array());
35 32
36 return *generator; 33 return *generator;
37 } 34 }
38 35
39 36
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 return NULL; 211 return NULL;
215 } 212 }
216 213
217 214
218 RUNTIME_FUNCTION(Runtime_GeneratorThrow) { 215 RUNTIME_FUNCTION(Runtime_GeneratorThrow) {
219 UNREACHABLE(); // Optimization disabled in SetUpGenerators(). 216 UNREACHABLE(); // Optimization disabled in SetUpGenerators().
220 return NULL; 217 return NULL;
221 } 218 }
222 } // namespace internal 219 } // namespace internal
223 } // namespace v8 220 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | test/mjsunit/es6/generators-iteration.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698