Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.h

Issue 1590863002: Move the local struct definitions off ui/base/ime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input_ime/input_ime_api.h
diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.h b/chrome/browser/extensions/api/input_ime/input_ime_api.h
index b5889ed3343ac3191fb59aa738010264f4b35d24..738aaed010f118afdf28a327968c186109c5b060 100644
--- a/chrome/browser/extensions/api/input_ime/input_ime_api.h
+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.h
@@ -14,6 +14,7 @@
#include "base/scoped_observer.h"
#include "base/values.h"
#include "build/build_config.h"
+#include "chrome/browser/input_method/input_method_engine_base.h"
#include "chrome/browser/profiles/profile.h"
#include "components/keyed_service/core/keyed_service.h"
#include "extensions/browser/browser_context_keyed_api_factory.h"
@@ -22,7 +23,6 @@
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/extension.h"
#include "ui/base/ime/ime_engine_handler_interface.h"
-#include "ui/base/ime/ime_engine_observer.h"
#include "ui/base/ime/text_input_flags.h"
#if defined(OS_CHROMEOS)
@@ -35,21 +35,20 @@ class Profile;
namespace ui {
class IMEEngineHandlerInterface;
-class IMEEngineObserver;
-class ImeObserver : public IMEEngineObserver {
+class ImeObserver : public input_method::InputMethodEngineBase::Observer {
public:
ImeObserver(const std::string& extension_id, Profile* profile);
~ImeObserver() override {}
- // IMEEngineObserver overrides.
+ // input_method::InputMethodEngineBase::Observer overrides.
void OnActivate(const std::string& component_id) override;
void OnFocus(const IMEEngineHandlerInterface::InputContext& context) override;
void OnBlur(int context_id) override;
void OnKeyEvent(
const std::string& component_id,
- const IMEEngineHandlerInterface::KeyboardEvent& event,
+ const input_method::InputMethodEngineBase::KeyboardEvent& event,
IMEEngineHandlerInterface::KeyEventDoneCallback& key_data) override;
void OnReset(const std::string& component_id) override;
void OnDeactivated(const std::string& component_id) override;

Powered by Google App Engine
This is Rietveld 408576698