Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1590863002: Move the local struct definitions off ui/base/ime. (Closed)

Created:
4 years, 11 months ago by Azure Wei
Modified:
4 years, 11 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the local struct defines from ui::IMEEngineHandlerInterface/ui::IMEEngineObserver to input_method::InputMethodEngineBase. Currently, some structs like KeyboardEvent are MouseButtonEvent are defined under ui/base/ime/, but not is not exported by the component library. These structs are used for InputMethodEngine for translating the Chrome IME API to the native. They are not suppose to be used and exported in ui/base/ime. This CL moves the following structs: KeyboardEvent, SegmentStyle, SegmentInfo and related functions from ui::IMEEngineHandlerInterface to input_method::InputMethodEngineBase. Moves the other structs: MenuItemStyle, CandidateWindowPosition, MenuItem, UsageEntry, Candidate, CandidateWindowProperty and the relate functions from ui::IMEEngineHandlerInterface to chromeos::InputMethodEngine, as these are all ChromeOS specific structs. And moves the whole class: ui::IMEEngineObserver to input_method::InputMethodEngineBase::Observer. BUG=517773 TEST=No compiling errors. Committed: https://crrev.com/1c9621e940227de56b55f2da1c889a0bfc53e521 Cr-Commit-Position: refs/heads/master@{#369979}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Delete class ui::IMEEngineObserver. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -483 lines) Patch
M chrome/browser/chromeos/input_method/input_method_engine.h View 1 4 chunks +88 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 4 chunks +25 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_unittest.cc View 1 6 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.h View 3 chunks +1 line, -29 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 1 2 25 chunks +46 lines, -46 lines 0 comments Download
M chrome/browser/input_method/input_method_engine_base.h View 1 6 chunks +108 lines, -11 lines 0 comments Download
M chrome/browser/input_method/input_method_engine_base.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M ui/base/ime/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 3 chunks +0 lines, -25 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.cc View 3 chunks +0 lines, -37 lines 0 comments Download
M ui/base/ime/ime_engine_handler_interface.h View 5 chunks +0 lines, -133 lines 0 comments Download
D ui/base/ime/ime_engine_handler_interface.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M ui/base/ime/ime_engine_observer.h View 1 1 chunk +0 lines, -81 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Azure Wei
Hi Shu, can you please review this CL? Thank you!
4 years, 11 months ago (2016-01-15 13:10:53 UTC) #3
Shu Chen
https://codereview.chromium.org/1590863002/diff/1/ui/base/ime/ime_engine_observer.h File ui/base/ime/ime_engine_observer.h (right): https://codereview.chromium.org/1590863002/diff/1/ui/base/ime/ime_engine_observer.h#newcode13 ui/base/ime/ime_engine_observer.h:13: class IMEEngineObserver { The whole IMEEngineObserver can be moved ...
4 years, 11 months ago (2016-01-15 13:46:23 UTC) #4
Azure Wei
On 2016/01/15 13:46:23, Shu Chen wrote: > https://codereview.chromium.org/1590863002/diff/1/ui/base/ime/ime_engine_observer.h > File ui/base/ime/ime_engine_observer.h (right): > > https://codereview.chromium.org/1590863002/diff/1/ui/base/ime/ime_engine_observer.h#newcode13 ...
4 years, 11 months ago (2016-01-17 04:43:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590863002/40001
4 years, 11 months ago (2016-01-17 14:31:13 UTC) #8
Shu Chen
lgtm
4 years, 11 months ago (2016-01-17 14:55:47 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/9706)
4 years, 11 months ago (2016-01-17 20:33:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590863002/40001
4 years, 11 months ago (2016-01-18 01:51:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-18 02:53:36 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 02:54:47 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c9621e940227de56b55f2da1c889a0bfc53e521
Cr-Commit-Position: refs/heads/master@{#369979}

Powered by Google App Engine
This is Rietveld 408576698