Chromium Code Reviews
DescriptionMove the local struct defines from ui::IMEEngineHandlerInterface/ui::IMEEngineObserver
to input_method::InputMethodEngineBase.
Currently, some structs like KeyboardEvent are MouseButtonEvent are defined under ui/base/ime/, but not is not exported by the component library.
These structs are used for InputMethodEngine for translating the Chrome IME API to the native. They are not suppose to be used and exported in ui/base/ime.
This CL moves the following structs:
KeyboardEvent, SegmentStyle, SegmentInfo
and related functions from ui::IMEEngineHandlerInterface to input_method::InputMethodEngineBase.
Moves the other structs:
MenuItemStyle, CandidateWindowPosition, MenuItem, UsageEntry, Candidate, CandidateWindowProperty
and the relate functions from ui::IMEEngineHandlerInterface to chromeos::InputMethodEngine, as these are all ChromeOS specific structs.
And moves the whole class:
ui::IMEEngineObserver
to input_method::InputMethodEngineBase::Observer.
BUG=517773
TEST=No compiling errors.
Committed: https://crrev.com/1c9621e940227de56b55f2da1c889a0bfc53e521
Cr-Commit-Position: refs/heads/master@{#369979}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Delete class ui::IMEEngineObserver. #Patch Set 3 : #Messages
Total messages: 17 (8 generated)
|