chrome/browser/extensions/api/input_ime/input_ime_api.cc - Issue 1590863002: Move the local struct definitions off ui/base/ime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.cc

Issue 1590863002: Move the local struct definitions off ui/base/ime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/input_ime/input_ime_api.cc

diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.cc b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

index 87fe3aa9568c681de6662e8deb7f0bd5501d7070..1ce5be01e3624331ff7ad2ac492af82b258dcead 100644

--- a/chrome/browser/extensions/api/input_ime/input_ime_api.cc

+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.cc

@@ -11,6 +11,7 @@

namespace input_ime = extensions::api::input_ime;

namespace KeyEventHandled = extensions::api::input_ime::KeyEventHandled;

using ui::IMEEngineHandlerInterface;

+using input_method::InputMethodEngineBase;

namespace ui {

@@ -61,7 +62,7 @@ void ImeObserver::OnBlur(int context_id) {

void ImeObserver::OnKeyEvent(

const std::string& component_id,

- const IMEEngineHandlerInterface::KeyboardEvent& event,

+ const InputMethodEngineBase::KeyboardEvent& event,

IMEEngineHandlerInterface::KeyEventDoneCallback& key_data) {

if (extension_id_.empty())

return;