Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: ui/base/ime/ime_engine_observer.h

Issue 1590863002: Move the local struct definitions off ui/base/ime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/ime_engine_handler_interface.cc ('k') | ui/base/ime/ui_base_ime.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/ime_engine_observer.h
diff --git a/ui/base/ime/ime_engine_observer.h b/ui/base/ime/ime_engine_observer.h
index 7a2bf9d2682c2a15c66482abb245dd12063a1619..c03b8065da29a2e23f8bf449c7282148d930e153 100644
--- a/ui/base/ime/ime_engine_observer.h
+++ b/ui/base/ime/ime_engine_observer.h
@@ -24,12 +24,6 @@ class IMEEngineObserver {
// Called when a text field loses focus, and will no longer generate events.
virtual void OnBlur(int context_id) = 0;
- // Called when the user pressed a key with a text field focused.
- virtual void OnKeyEvent(
- const std::string& engine_id,
- const IMEEngineHandlerInterface::KeyboardEvent& event,
- IMEEngineHandlerInterface::KeyEventDoneCallback& key_data) = 0;
-
// Called when Chrome terminates on-going text input session.
virtual void OnReset(const std::string& engine_id) = 0;
@@ -49,31 +43,15 @@ class IMEEngineObserver {
int cursor_pos,
int anchor_pos,
int offset_pos) = 0;
-
-// ChromeOS only APIs.
#if defined(OS_CHROMEOS)
-
- enum MouseButtonEvent {
- MOUSE_BUTTON_LEFT,
- MOUSE_BUTTON_RIGHT,
- MOUSE_BUTTON_MIDDLE,
- };
-
// Called when an InputContext's properties change while it is focused.
virtual void OnInputContextUpdate(
const IMEEngineHandlerInterface::InputContext& context) = 0;
-
-
- // Called when the user clicks on an item in the candidate list.
- virtual void OnCandidateClicked(const std::string& engine_id,
- int candidate_id,
- MouseButtonEvent button) = 0;
-
// Called when a menu item for this IME is interacted with.
- virtual void OnMenuItemActivated(const std::string& engine_id,
+ virtual void OnMenuItemActivated(const std::string& component_id,
const std::string& menu_id) = 0;
-#endif
+#endif // defined(OS_CHROMEOS)
};
} // namespace ui
« no previous file with comments | « ui/base/ime/ime_engine_handler_interface.cc ('k') | ui/base/ime/ui_base_ime.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698