Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 15906014: MIPS: Fix abs_d instruction in the simulator. (Closed)

Created:
7 years, 6 months ago by palfia
Modified:
7 years, 6 months ago
Reviewers:
kisg, Paul Lind, kilvadyb, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix abs_d instruction in the simulator. The abs_d instruction was implemented wrongly in the simulator, it doesn't reverse the sign of the -0 number. This commit fixes the abs_d instruction implementation. TEST=msjunit/math-abs BUG= Committed: https://code.google.com/p/v8/source/detail?r=15053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 6 months ago (2013-06-10 20:40:11 UTC) #1
Paul Lind
LGTM, thanks for the fix!
7 years, 6 months ago (2013-06-10 21:47:10 UTC) #2
palfia
7 years, 6 months ago (2013-06-10 21:54:14 UTC) #3
Message was sent while issue was closed.
Committed manually as r15053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698