Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1590533006:
Support Slot.getAssignedNodes({flatten: true}) in a document tree. (Closed)
|
Created:
4 years, 11 months ago by hayato Modified:
4 years, 11 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@v1-descendant-slots Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport Slot.getAssignedNodes({flatten: true}) in a document tree.
The spec is: https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssignedNodes-sequence-Node--AssignedNodesOptions-options
BUG=531990
Committed: https://crrev.com/fd8982260f5903845f5bffd6d002b5e2c5ab09e7
Cr-Commit-Position: refs/heads/master@{#370667}
Patch Set 1 #Patch Set 2 : update TODO comment #Patch Set 3 : rebased #
Messages
Total messages: 28 (13 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590533006/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
Description was changed from ========== Support Slot.getDistributedNodes() even when it is in a document tree. BUG= ========== to ========== Support Slot.getDistributedNodes() even when it is in a document tree. The spec is: http://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getDistr... BUG=531990 ==========
hayato@chromium.org changed reviewers: + kochi@chromium.org, tkent@chromium.org
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
update TODO comment
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590533006/20001
Description was changed from ========== Support Slot.getDistributedNodes() even when it is in a document tree. The spec is: http://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getDistr... BUG=531990 ========== to ========== Support Slot.getDistributedNodes() in a document tree. The spec is: http://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getDistr... BUG=531990 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
getDistributedNodes() is already renamed to
getAssignedNodes({flatten: true}), right?
You also need to update the description and
the link to the spec.
Description was changed from ========== Support Slot.getDistributedNodes() in a document tree. The spec is: http://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getDistr... BUG=531990 ========== to ========== Support Slot.getAssignedNodes({flatten: true}) in a document tree. The spec is: https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssi... BUG=531990 ==========
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
rebased
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590533006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590533006/40001
On 2016/01/21 07:58:07, kochi wrote:
> getDistributedNodes() is already renamed to
> getAssignedNodes({flatten: true}), right?
>
> You also need to update the description and
> the link to the spec.
Yeah, I forgot to rebase this.
Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590533006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590533006/40001
Message was sent while issue was closed.
Description was changed from
==========
Support Slot.getAssignedNodes({flatten: true}) in a document tree.
The spec is:
https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssi...
BUG=531990
==========
to
==========
Support Slot.getAssignedNodes({flatten: true}) in a document tree.
The spec is:
https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssi...
BUG=531990
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Support Slot.getAssignedNodes({flatten: true}) in a document tree.
The spec is:
https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssi...
BUG=531990
==========
to
==========
Support Slot.getAssignedNodes({flatten: true}) in a document tree.
The spec is:
https://w3c.github.io/webcomponents/spec/shadow/#widl-HTMLSlotElement-getAssi...
BUG=531990
Committed: https://crrev.com/fd8982260f5903845f5bffd6d002b5e2c5ab09e7
Cr-Commit-Position: refs/heads/master@{#370667}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fd8982260f5903845f5bffd6d002b5e2c5ab09e7 Cr-Commit-Position: refs/heads/master@{#370667} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
