third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 1590533006: Support Slot.getAssignedNodes({flatten: true}) in a document tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 1590533006: Support Slot.getAssignedNodes({flatten: true}) in a document tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v1-descendant-slots

Patch Set: rebased Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-in-document-tree.html ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index b674bc751fc47b07591b496c662544179dc39789..c5e5082d28b407feb8c1add32d60ed2a929801e8 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -44,8 +44,7 @@ public:

DECLARE_NODE_FACTORY(HTMLSlotElement);

const WillBeHeapVector<RefPtrWillBeMember<Node>>& getAssignedNodes() const { ASSERT(!needsDistributionRecalc()); return m_assignedNodes; }

- const WillBeHeapVector<RefPtrWillBeMember<Node>>& getDistributedNodes() const { ASSERT(!needsDistributionRecalc()); return m_distributedNodes; }

+ const WillBeHeapVector<RefPtrWillBeMember<Node>>& getDistributedNodes();

const WillBeHeapVector<RefPtrWillBeMember<Node>> getAssignedNodesForBinding(const AssignedNodesOptions&);

Node* firstDistributedNode() const { return m_distributedNodes.isEmpty() ? nullptr : m_distributedNodes.first().get(); }