Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1590273002: [runtime] No need to carry around the creation context for JSBoundFunctions. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] No need to carry around the creation context for JSBoundFunctions. We can return the creation context of the [[BoundTargetFunction]], and don't need to remember the context in which the function was bound. R=verwaest@chromium.org BUG=chromium:535408 LOG=n Committed: https://crrev.com/f23985d767f3a2517f881dc740446dc8be2438c6 Cr-Commit-Position: refs/heads/master@{#33332}

Patch Set 1 #

Patch Set 2 : Fix debug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +1 line, -9 lines 0 comments Download
M src/objects.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-15 13:05:04 UTC) #1
Benedikt Meurer
Hey Toon, Here's the change for JSBoundFunction that we just discussed. Please take a look. ...
4 years, 11 months ago (2016-01-15 13:05:54 UTC) #2
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-15 14:08:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590273002/20001
4 years, 11 months ago (2016-01-15 14:09:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 14:14:03 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 14:15:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f23985d767f3a2517f881dc740446dc8be2438c6
Cr-Commit-Position: refs/heads/master@{#33332}

Powered by Google App Engine
This is Rietveld 408576698