src/objects-debug.cc - Issue 1590273002: [runtime] No need to carry around the creation context for JSBoundFunctions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 1590273002: [runtime] No need to carry around the creation context for JSBoundFunctions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix debug. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index b6dd42553cf404d8af27ce89d829a0efbfeff338..cf9f5b711ea7f8982ec08c4cc3426698f1b7bd5a 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -553,9 +553,7 @@ void JSBoundFunction::JSBoundFunctionVerify() {

VerifyObjectField(kBoundThisOffset);

VerifyObjectField(kBoundTargetFunctionOffset);

VerifyObjectField(kBoundArgumentsOffset);

- VerifyObjectField(kCreationContextOffset);

CHECK(bound_target_function()->IsCallable());

- CHECK(creation_context()->IsNativeContext());

CHECK(IsCallable());

CHECK_EQ(IsConstructor(), bound_target_function()->IsConstructor());

}

« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »