third_party/WebKit/Source/core/dom/Element.cpp - Issue 1590143002: removeBetween() -> detach() performance fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1590143002: removeBetween() -> detach() performance fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check needsStyleInvalidation() before clearing. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 0b9901e0462d4bc16e50dac344155b883aa12076..413421a04832ad050086e7a566168cfb3310d299 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1530,6 +1530,9 @@ void Element::removedFrom(ContainerNode* insertionPoint)

if (isUpgradedCustomElement())

CustomElement::didDetach(this, insertionPoint->document());

+ if (needsStyleInvalidation())

+ document().styleEngine().styleInvalidator().clearInvalidation(*this);

}

document().removeFromTopLayer(this);

« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »