third_party/WebKit/Source/core/dom/ContainerNode.cpp - Issue 1590143002: removeBetween() -> detach() performance fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1590143002: removeBetween() -> detach() performance fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check needsStyleInvalidation() before clearing. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

index 832952dc10b03caca5e147001b3f0f4e2251245a..2ee1257276b57493dbe2713a342f4d9e6fd0b660 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

@@ -606,7 +606,7 @@ void ContainerNode::removeBetween(Node* previousChild, Node* nextChild, Node& ol

AttachContext context;

context.clearInvalidation = true;

- if (!needsAttach() || !oldChild.needsAttach())

+ if (!oldChild.needsAttach())

oldChild.detach(context);

if (nextChild)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »