Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 159013002: Remove obsolete stack trace string in a message object. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Remove obsolete stack trace string in a message object. The stack trace string is an ancient relic that is no longer being used. We use the structured stack trace object instead. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -28 lines) Patch
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 10 months ago (2014-02-10 16:14:28 UTC) #1
Benedikt Meurer
LGTM
6 years, 10 months ago (2014-02-11 06:49:28 UTC) #2
Yang
6 years, 10 months ago (2014-02-11 09:30:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698