Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: src/debug.cc

Issue 159013002: Remove obsolete stack trace string in a message object. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 NULL, 785 NULL,
786 &caught_exception); 786 &caught_exception);
787 787
788 // Check for caught exceptions. 788 // Check for caught exceptions.
789 if (caught_exception) { 789 if (caught_exception) {
790 ASSERT(!isolate->has_pending_exception()); 790 ASSERT(!isolate->has_pending_exception());
791 MessageLocation computed_location; 791 MessageLocation computed_location;
792 isolate->ComputeLocation(&computed_location); 792 isolate->ComputeLocation(&computed_location);
793 Handle<Object> message = MessageHandler::MakeMessageObject( 793 Handle<Object> message = MessageHandler::MakeMessageObject(
794 isolate, "error_loading_debugger", &computed_location, 794 isolate, "error_loading_debugger", &computed_location,
795 Vector<Handle<Object> >::empty(), Handle<String>(), Handle<JSArray>()); 795 Vector<Handle<Object> >::empty(), Handle<JSArray>());
796 ASSERT(!isolate->has_pending_exception()); 796 ASSERT(!isolate->has_pending_exception());
797 if (!exception.is_null()) { 797 if (!exception.is_null()) {
798 isolate->set_pending_exception(*exception); 798 isolate->set_pending_exception(*exception);
799 MessageHandler::ReportMessage(isolate, NULL, message); 799 MessageHandler::ReportMessage(isolate, NULL, message);
800 isolate->clear_pending_exception(); 800 isolate->clear_pending_exception();
801 } 801 }
802 return false; 802 return false;
803 } 803 }
804 804
805 // Mark this script as native and return successfully. 805 // Mark this script as native and return successfully.
(...skipping 2998 matching lines...) Expand 10 before | Expand all | Expand 10 after
3804 { 3804 {
3805 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_)); 3805 Locker locker(reinterpret_cast<v8::Isolate*>(isolate_));
3806 isolate_->debugger()->CallMessageDispatchHandler(); 3806 isolate_->debugger()->CallMessageDispatchHandler();
3807 } 3807 }
3808 } 3808 }
3809 } 3809 }
3810 3810
3811 #endif // ENABLE_DEBUGGER_SUPPORT 3811 #endif // ENABLE_DEBUGGER_SUPPORT
3812 3812
3813 } } // namespace v8::internal 3813 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698