Move window.crypto to modules/crypto

Move window.crypto to modules/crypto.

BUG=245025
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152261

[eroman, 2013-06-11 21:55:54]

Adam, would you be willing to be a reviewer for the webcrypto implementation?

Here is the first CL.

Thanks!

[abarth-chromium, 2013-06-11 21:58:53]

LGTM!

https://codereview.chromium.org/15901021/diff/1/Source/bindings/v8/custom/V8C...
File Source/bindings/v8/custom/V8CryptoCustom.cpp (right):

https://codereview.chromium.org/15901021/diff/1/Source/bindings/v8/custom/V8C...
Source/bindings/v8/custom/V8CryptoCustom.cpp:38: void
V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
args)
Why doe this need to be custom?  It seems like it's just doing the same thing th
ecode generator would do.

https://codereview.chromium.org/15901021/diff/1/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/15901021/diff/1/Source/modules/modules.gypi#n...
Source/modules/modules.gypi:152: 'webcrypto/DOMWindowCrypto.idl',
webcrypto -> crypto ?  The "web" seems unnecessary.

[Ryan Sleevi, 2013-06-11 22:05:42]

https://codereview.chromium.org/15901021/diff/1/Source/bindings/v8/custom/V8C...
File Source/bindings/v8/custom/V8CryptoCustom.cpp (right):

https://codereview.chromium.org/15901021/diff/1/Source/bindings/v8/custom/V8C...
Source/bindings/v8/custom/V8CryptoCustom.cpp:38: void
V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
args)
On 2013/06/11 21:58:53, abarth wrote:
> Why doe this need to be custom?  It seems like it's just doing the same thing
th
> ecode generator would do.

See https://bugs.webkit.org/show_bug.cgi?id=104845

It's because the bindings generator isn't smart enough to return the 'right'
type of ArrayBufferView that was supplied in the input. We cheat here and return
|buffer| as a v8::Value that we know is a V8ArrayBufferView, without having to
worry about creating the right type of DOM wrapper again.

This was suggested by haraken@ after much discussion.

[eroman, 2013-06-11 22:10:38]

Thanks!

https://codereview.chromium.org/15901021/diff/1/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/15901021/diff/1/Source/modules/modules.gypi#n...
Source/modules/modules.gypi:152: 'webcrypto/DOMWindowCrypto.idl',
On 2013/06/11 21:58:53, abarth wrote:
> webcrypto -> crypto ?  The "web" seems unnecessary.

Done.

[commit-bot: I haz the power, 2013-06-11 22:14:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/15901021/7001

[abarth-chromium, 2013-06-11 23:15:43]

On 2013/06/11 22:05:42, Ryan Sleevi wrote:
> This was suggested by haraken@ after much discussion.

Ah, thanks for the reference.

[commit-bot: I haz the power, 2013-06-12 00:22:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-12 00:38:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/15901021/22001

[commit-bot: I haz the power, 2013-06-12 04:02:10]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[eroman, 2013-06-12 04:17:29]

Committed patchset #3 manually as r152261 (presubmit successful).