Move window.crypto to modules/crypto

Source/bindings/v8/custom/V8CryptoCustom.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 11 matching lines @@
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "V8Crypto.h"
 
 #include "V8ArrayBufferView.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8Utilities.h"
 #include "core/dom/ExceptionCode.h"
-#include "core/page/Crypto.h"
+#include "modules/webcrypto/Crypto.h"
 
 #include "wtf/ArrayBufferView.h"
 
 namespace WebCore {
 
 void V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)

[abarth-chromium, 2013/06/11 21:58:53]

Why doe this need to be custom?  It seems like it's just doing the same thing th
ecode generator would do.

[Ryan Sleevi, 2013/06/11 22:05:42]

See https://bugs.webkit.org/show_bug.cgi?id=104845

It's because the bindings generator isn't smart enough to return the 'right'
type of ArrayBufferView that was supplied in the input. We cheat here and return
|buffer| as a v8::Value that we know is a V8ArrayBufferView, without having to
worry about creating the right type of DOM wrapper again.

This was suggested by haraken@ after much discussion.

 {
     if (args.Length() < 1) {
         throwNotEnoughArgumentsError(args.GetIsolate());
         return;
     }
 
     v8::Handle<v8::Value> buffer = args[0];
     if (!V8ArrayBufferView::HasInstance(buffer, args.GetIsolate(), worldType(args.GetIsolate()))) {
         throwTypeError("First argument is not an ArrayBufferView", args.GetIsolate());
         return;
     }
 
     ArrayBufferView* arrayBufferView = V8ArrayBufferView::toNative(v8::Handle<v8::Object>::Cast(buffer));
     ASSERT(arrayBufferView);
 
     Crypto* crypto = V8Crypto::toNative(args.Holder());
     ExceptionCode ec = 0;
     crypto->getRandomValues(arrayBufferView, ec);
 
     if (ec) {
         setDOMException(ec, args.GetIsolate());
         return;
     }
 
     v8SetReturnValue(args, buffer);
 }
 
 } // namespace WebCore