src/a64/macro-assembler-a64.cc - Issue 159003003: A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/macro-assembler-a64.cc

Issue 159003003: A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/a64/macro-assembler-a64.cc

diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc

index 84269cf6f07b6cc21fdb20655577feb273d837fc..6713b248b27ec04553d705fb76c4249d49900709 100644

--- a/src/a64/macro-assembler-a64.cc

+++ b/src/a64/macro-assembler-a64.cc

@@ -1340,7 +1340,7 @@ void MacroAssembler::CallApiFunctionAndReturn(

next_address);

ASSERT(function_address.Is(x3));

- ASSERT(!AreAliased(function_address, thunk_last_arg, x1, x2));

+ ASSERT(thunk_last_arg.is(x1) || thunk_last_arg.is(x2));

ulan 2014/02/10 16:38:51 I took this assert from the ARM port, which also u

// TODO(all): Why do we care about aliasing x2? (This function uses x1 as a

// scratch regiser.)

« no previous file with comments | « no previous file | no next file » | no next file with comments »