Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: src/a64/macro-assembler-a64.cc

Issue 159003003: A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1322 matching lines...) Expand 10 before | Expand all | Expand 10 after
1333 ExternalReference::handle_scope_next_address(isolate()); 1333 ExternalReference::handle_scope_next_address(isolate());
1334 const int kNextOffset = 0; 1334 const int kNextOffset = 0;
1335 const int kLimitOffset = AddressOffset( 1335 const int kLimitOffset = AddressOffset(
1336 ExternalReference::handle_scope_limit_address(isolate()), 1336 ExternalReference::handle_scope_limit_address(isolate()),
1337 next_address); 1337 next_address);
1338 const int kLevelOffset = AddressOffset( 1338 const int kLevelOffset = AddressOffset(
1339 ExternalReference::handle_scope_level_address(isolate()), 1339 ExternalReference::handle_scope_level_address(isolate()),
1340 next_address); 1340 next_address);
1341 1341
1342 ASSERT(function_address.Is(x3)); 1342 ASSERT(function_address.Is(x3));
1343 ASSERT(!AreAliased(function_address, thunk_last_arg, x1, x2)); 1343 ASSERT(thunk_last_arg.is(x1) || thunk_last_arg.is(x2));
ulan 2014/02/10 16:38:51 I took this assert from the ARM port, which also u
1344 // TODO(all): Why do we care about aliasing x2? (This function uses x1 as a 1344 // TODO(all): Why do we care about aliasing x2? (This function uses x1 as a
1345 // scratch regiser.) 1345 // scratch regiser.)
1346 1346
1347 // TODO(all): Why isn't thunk_last_arg used? 1347 // TODO(all): Why isn't thunk_last_arg used?
1348 USE(thunk_last_arg); 1348 USE(thunk_last_arg);
1349 1349
1350 Label profiler_disabled; 1350 Label profiler_disabled;
1351 Label end_profiler_check; 1351 Label end_profiler_check;
1352 bool* is_profiling_flag = isolate()->cpu_profiler()->is_profiling_address(); 1352 bool* is_profiling_flag = isolate()->cpu_profiler()->is_profiling_address();
1353 STATIC_ASSERT(sizeof(*is_profiling_flag) == 1); 1353 STATIC_ASSERT(sizeof(*is_profiling_flag) == 1);
(...skipping 3451 matching lines...) Expand 10 before | Expand all | Expand 10 after
4805 } 4805 }
4806 } 4806 }
4807 4807
4808 4808
4809 #undef __ 4809 #undef __
4810 4810
4811 4811
4812 } } // namespace v8::internal 4812 } } // namespace v8::internal
4813 4813
4814 #endif // V8_TARGET_ARCH_A64 4814 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698