Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 159003003: A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
Reviewers:
m.m.capewell, dcarney
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix assertion in MacroAssembler::CallApiFunctionAndReturn.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/a64/macro-assembler-a64.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
ulan
Dan, the ARM port uses r1 as a scratch, is this correct? Why don't we ...
6 years, 10 months ago (2014-02-10 16:38:51 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-10 17:10:22 UTC) #2
m.m.capewell
lgtm
6 years, 10 months ago (2014-02-10 17:14:43 UTC) #3
ulan
6 years, 10 months ago (2014-02-10 17:40:45 UTC) #4
The latest rebase removed this assertion. Closing the issue.

Powered by Google App Engine
This is Rietveld 408576698