Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1589923002: Add more layout test cases to createImageBitmap (Closed)

Created:
4 years, 11 months ago by xidachen
Modified:
4 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more layout test cases to createImageBitmap Comparing Firefox's layout tests against Chrome's, we find that there are two cases that is currently missing in our code base. 1). createImageBitmap from a neutered ImageBitmap. 2). createImageBitmap from a Blob object that is created by canvas.toBlob This CL adds these two test cases. Committed: https://crrev.com/e6fc1bec903a7e7d6c606f4df9b30cb1a2db7001 Cr-Commit-Position: refs/heads/master@{#369443}

Patch Set 1 #

Total comments: 3

Patch Set 2 : nit #

Patch Set 3 : update layout test result #

Messages

Total messages: 18 (9 generated)
xidachen
PTAL
4 years, 11 months ago (2016-01-14 14:06:37 UTC) #2
Justin Novosad
lgtm with nits https://codereview.chromium.org/1589923002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-from-canvas-toBlob.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-from-canvas-toBlob.html (right): https://codereview.chromium.org/1589923002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-from-canvas-toBlob.html#newcode38 third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-from-canvas-toBlob.html:38: createImageBitmap(blob).then(imageBitmap => { As discussed on ...
4 years, 11 months ago (2016-01-14 15:02:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589923002/1
4 years, 11 months ago (2016-01-14 15:04:15 UTC) #5
Justin Novosad
Sorry I forgot to save my said "nits"...
4 years, 11 months ago (2016-01-14 15:05:52 UTC) #7
Justin Novosad
https://codereview.chromium.org/1589923002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html (right): https://codereview.chromium.org/1589923002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html#newcode46 third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html:46: testFailed("Unexpected failure"); "Promise accepted, expected to be rejected" https://codereview.chromium.org/1589923002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-transferable.html#newcode49 ...
4 years, 11 months ago (2016-01-14 15:06:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589923002/20001
4 years, 11 months ago (2016-01-14 15:12:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589923002/40001
4 years, 11 months ago (2016-01-14 15:59:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 17:14:39 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:16:20 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e6fc1bec903a7e7d6c606f4df9b30cb1a2db7001
Cr-Commit-Position: refs/heads/master@{#369443}

Powered by Google App Engine
This is Rietveld 408576698