Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: Source/bindings/v8/custom/V8StorageCustom.cpp

Issue 15899009: Support indexed setter generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8StorageCustom.cpp
diff --git a/Source/bindings/v8/custom/V8StorageCustom.cpp b/Source/bindings/v8/custom/V8StorageCustom.cpp
index 43825b479c679aad1ba35894d626e4d5a03169b1..a6bfbb1043dea6228d10f2183980a134829c9615 100644
--- a/Source/bindings/v8/custom/V8StorageCustom.cpp
+++ b/Source/bindings/v8/custom/V8StorageCustom.cpp
@@ -81,33 +81,6 @@ v8::Handle<v8::Integer> V8Storage::namedPropertyQuery(v8::Local<v8::String> v8Na
return v8Integer(0, info.GetIsolate());
}
-static v8::Handle<v8::Value> storageSetter(v8::Local<v8::String> v8Name, v8::Local<v8::Value> v8Value, const v8::AccessorInfo& info)
-{
- Storage* storage = V8Storage::toNative(info.Holder());
- String name = toWebCoreString(v8Name);
- String value = toWebCoreString(v8Value);
-
- // Silently ignore length (rather than letting the bindings raise an exception).
- if (name == "length")
- return v8Value;
-
- if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(v8Name).IsEmpty())
- return v8Undefined();
-
- ExceptionCode ec = 0;
- storage->setItem(name, value, ec);
- if (ec)
- return setDOMException(ec, info.GetIsolate());
-
- return v8Value;
-}
-
-v8::Handle<v8::Value> V8Storage::indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
-{
- v8::Handle<v8::Integer> indexV8 = v8Integer(index, info.GetIsolate());
- return storageSetter(indexV8->ToString(), value, info);
-}
-
static v8::Handle<v8::Boolean> storageDeleter(v8::Local<v8::String> v8Name, const v8::AccessorInfo& info)
{
Storage* storage = V8Storage::toNative(info.Holder());

Powered by Google App Engine
This is Rietveld 408576698