Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 15899009: Support indexed setter generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index 1b0fc3a7f21d4e4a8b552e1c454d32f101665808..f805295647b1b49e88759c13fde9c447178a872c 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -187,7 +187,7 @@ v8::Handle<v8::Value> V8TestEventTarget::namedPropertySetter(v8::Local<v8::Strin
TestEventTarget* collection = toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
- bool result = collection->anonymousNamedSetter(propertyName, propertyValue);
+ bool result = collection->anonymousNamedSetter(propertyName, propertyValue, value->IsNull(), value->IsUndefined());
kojih 2013/05/28 06:51:28 In HTMLSelectElement and HTMLOptionsCollection, in
haraken 2013/05/28 07:02:43 This is dirty... How do other browsers behave? I
if (!result)
return v8Undefined();
return value;

Powered by Google App Engine
This is Rietveld 408576698