Support indexed setter generation

Support indexed setter generation

If JS value is null and [TreatNullAs=functionName],
functionName(name/index) is called instead of normal setter.

Using the feature, following custom implementation has been removed.
- V8HTMLOptionsCollection::indexedPropertySetter
- V8HTMLSelectElement::indexedPropertySetter
- V8Storage::indexedPropertySetter

R=haraken@chromium.org
BUG=229740
TEST=TestEventTarget.idl
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151449

[kojih, 2013-05-28 06:51:28]

r?

Diff of generated code:

diff -u /mnt/hdd/diff/gen_sti/V8CSSStyleDeclaration.cpp
/mnt/hdd/diff/gen_oc/V8CSSStyleDeclaration.cpp
--- /mnt/hdd/diff/gen_sti/V8CSSStyleDeclaration.cpp	2013-05-28
13:21:58.619992603 +0900
+++ /mnt/hdd/diff/gen_oc/V8CSSStyleDeclaration.cpp	2013-05-28 15:29:25.960288528
+0900
@@ -265,7 +265,7 @@
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
     ExceptionCode ec = 0;
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<WithNullCheck>,
propertyValue, value);
-    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
ec);
+    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
value->IsNull(), value->IsUndefined(), ec);
     if (!result)
         return v8Undefined();
     if (ec)
diff -u /mnt/hdd/diff/gen_sti/V8DOMStringMap.cpp
/mnt/hdd/diff/gen_oc/V8DOMStringMap.cpp
--- /mnt/hdd/diff/gen_sti/V8DOMStringMap.cpp	2013-05-28 13:21:58.619992603 +0900
+++ /mnt/hdd/diff/gen_oc/V8DOMStringMap.cpp	2013-05-28 15:29:25.970288608 +0900
@@ -89,7 +89,7 @@
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
     ExceptionCode ec = 0;
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
-    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
ec);
+    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
value->IsNull(), value->IsUndefined(), ec);
     if (!result)
         return v8Undefined();
     if (ec)
diff -u /mnt/hdd/diff/gen_sti/V8HTMLOptionsCollection.cpp
/mnt/hdd/diff/gen_oc/V8HTMLOptionsCollection.cpp
--- /mnt/hdd/diff/gen_sti/V8HTMLOptionsCollection.cpp	2013-05-28
13:21:58.629992681 +0900
+++ /mnt/hdd/diff/gen_oc/V8HTMLOptionsCollection.cpp	2013-05-28
15:29:25.980288689 +0900
@@ -23,6 +23,7 @@
 
 #include "RuntimeEnabledFeatures.h"
 #include "V8HTMLCollection.h"
+#include "V8HTMLOptionElement.h"
 #include "V8Node.h"
 #include "V8NodeList.h"
 #include "bindings/v8/ScriptController.h"
@@ -155,6 +156,19 @@
     return toV8Fast(element.release(), info, collection);
 }
 
+v8::Handle<v8::Value> V8HTMLOptionsCollection::indexedPropertySetter(uint32_t
index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    HTMLOptionsCollection* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    bool result = collection->anonymousIndexedSetter(index,
propertyValue.release(), value->IsNull(), value->IsUndefined(), ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 v8::Handle<v8::Value>
V8HTMLOptionsCollection::namedPropertyGetter(v8::Local<v8::String> name, const
v8::AccessorInfo& info)
 {
     if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
diff -u /mnt/hdd/diff/gen_sti/V8HTMLSelectElement.cpp
/mnt/hdd/diff/gen_oc/V8HTMLSelectElement.cpp
--- /mnt/hdd/diff/gen_sti/V8HTMLSelectElement.cpp	2013-05-28 13:21:58.629992681
+0900
+++ /mnt/hdd/diff/gen_oc/V8HTMLSelectElement.cpp	2013-05-28 15:29:25.980288689
+0900
@@ -26,6 +26,7 @@
 #include "V8HTMLCollection.h"
 #include "V8HTMLElement.h"
 #include "V8HTMLFormElement.h"
+#include "V8HTMLOptionElement.h"
 #include "V8HTMLOptionsCollection.h"
 #include "V8Node.h"
 #include "V8NodeList.h"
@@ -508,6 +509,19 @@
     return toV8Fast(element.release(), info, collection);
 }
 
+v8::Handle<v8::Value> V8HTMLSelectElement::indexedPropertySetter(uint32_t
index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    HTMLSelectElement* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    bool result = collection->anonymousIndexedSetter(index,
propertyValue.release(), value->IsNull(), value->IsUndefined(), ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 static v8::Persistent<v8::FunctionTemplate>
ConfigureV8HTMLSelectElementTemplate(v8::Persistent<v8::FunctionTemplate> desc,
v8::Isolate* isolate, WrapperWorldType currentWorldType)
 {
     desc->ReadOnlyPrototype();
diff -u /mnt/hdd/diff/gen_sti/V8Storage.cpp /mnt/hdd/diff/gen_oc/V8Storage.cpp
--- /mnt/hdd/diff/gen_sti/V8Storage.cpp	2013-05-28 13:21:58.639992758 +0900
+++ /mnt/hdd/diff/gen_oc/V8Storage.cpp	2013-05-28 15:29:25.980288689 +0900
@@ -274,6 +274,19 @@
     return v8String(element, info.GetIsolate());
 }
 
+v8::Handle<v8::Value> V8Storage::indexedPropertySetter(uint32_t index,
v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    Storage* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
+    bool result = collection->anonymousIndexedSetter(index, propertyValue,
value->IsNull(), value->IsUndefined(), ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 v8::Handle<v8::Value> V8Storage::namedPropertyGetter(v8::Local<v8::String>
name, const v8::AccessorInfo& info)
 {
     if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
@@ -303,7 +316,7 @@
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
     ExceptionCode ec = 0;
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
-    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
ec);
+    bool result = collection->anonymousNamedSetter(propertyName, propertyValue,
value->IsNull(), value->IsUndefined(), ec);
     if (!result)
         return v8Undefined();
     if (ec)

https://codereview.chromium.org/15899009/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15899009/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:3197: if ($type eq "DOMString") {
I'd like to remove this branch by modifying JSValueToNative in the following
patch.

https://codereview.chromium.org/15899009/diff/1/Source/bindings/tests/results...
File Source/bindings/tests/results/V8TestEventTarget.cpp (right):

https://codereview.chromium.org/15899009/diff/1/Source/bindings/tests/results...
Source/bindings/tests/results/V8TestEventTarget.cpp:190: bool result =
collection->anonymousNamedSetter(propertyName, propertyValue, value->IsNull(),
value->IsUndefined());
In HTMLSelectElement and HTMLOptionsCollection,
indexed setter remove the named element if JS value is null or undefined.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I think checking null/undefined in webcore layer is not special for
HTMLSelectElement and HTMLOptionsCollection,
so I added isValueNull and isValueUndefined parameter to all generated
indexed/named property setters.

[haraken, 2013-05-28 07:02:43]

https://codereview.chromium.org/15899009/diff/1/Source/bindings/tests/results...
File Source/bindings/tests/results/V8TestEventTarget.cpp (right):

https://codereview.chromium.org/15899009/diff/1/Source/bindings/tests/results...
Source/bindings/tests/results/V8TestEventTarget.cpp:190: bool result =
collection->anonymousNamedSetter(propertyName, propertyValue, value->IsNull(),
value->IsUndefined());

This is dirty...

How do other browsers behave?

If we need to add these parameters, can we use optional parameters?

[kojih, 2013-05-28 09:35:34]

Behavior of FireFox and Opera are same to chromium.
(at least when we pass null or undefined to indexed setter)
Test is:
LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

Summary:
var e = document.createElement("select")
e[0]=document.createElement("option")
e[0] // <option></option>
e[0]=null;  // value of index 0 is removed
e[0] // undefined
e[0]="a";   // Error: TypeMismatchError: DOM Exception 17

[kojih, 2013-05-28 09:41:05]

Using optional parameters means something like this?

bool Storage::anonymousIndexedSetter(unsigned index, const AtomicString& value,
ExceptionCode& ec, bool isValueNull=false, bool isValueUndefined=false)

I think this may not reduce dirtiness because generator always generates code
with value->isNull(), value->isUndefined()

Or do you mean adding new attributes like [PassIsNullAndIsUndefined] and control
pass additional 2 variables or not?

[haraken, 2013-05-28 10:24:27]

Thanks for the clarification. I looked at code and changed my mind:)

I guess there are a bunch of custom bindings that stay as custom just for
special behavior for a null case or a undefined case. How about making use of
[TreatNullAs=xxx] and [TreatUndefinedAs=xxx] ? For example, [TreatNullAs=remove]
means that remove() should be called when a null is passed.

[kojih, 2013-05-28 10:42:05]

[TreatNullAs=remove] will work for V8HTMLSelectElement,
but will not work for V8HTMLOptionsCollection.
because in that case collection->ownerNode()->remove(index) should be called.
(collection is HTMLOptionsCollection*, collection->ownerNode() is
HTMLSelectElement*)

see
https://codereview.chromium.org/15899009/diff/1/Source/core/html/HTMLOptionsC...

[haraken, 2013-05-28 11:02:02]

Can't you add a helper function to HTMLOptionsCollection.h that calls
collection->ownerNode()->remove(index)?

[kojih, 2013-05-28 11:20:54]

Oh it seems good idea. I'll try.

[kojih, 2013-05-29 03:55:22]

Support [TreatNullAs=*]/[TreatUndefinedAs=*].
r?

Now diff of generated code:

diff -u /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp
/mnt/hdd/diff/gen_oc/V8HTMLOptionsCollection.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLOptionsCollection.cpp	2013-05-29
11:55:10.086481733 +0900
+++ /mnt/hdd/diff/gen_oc/V8HTMLOptionsCollection.cpp	2013-05-29
12:45:25.300130338 +0900
@@ -23,6 +23,7 @@
 
 #include "RuntimeEnabledFeatures.h"
 #include "V8HTMLCollection.h"
+#include "V8HTMLOptionElement.h"
 #include "V8Node.h"
 #include "V8NodeList.h"
 #include "bindings/v8/ScriptController.h"
@@ -155,6 +156,25 @@
     return toV8Fast(element.release(), info, collection);
 }
 
+v8::Handle<v8::Value> V8HTMLOptionsCollection::indexedPropertySetter(uint32_t
index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    HTMLOptionsCollection* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    bool result;
+    if (value->IsNull())
+        result = collection->anonymousIndexedSetterRemove(index, ec);
+    else if (value->IsUndefined())
+        result = collection->anonymousIndexedSetterRemove(index, ec);
+    else
+        result = collection->anonymousIndexedSetter(index,
propertyValue.release(), ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 v8::Handle<v8::Value>
V8HTMLOptionsCollection::namedPropertyGetter(v8::Local<v8::String> name, const
v8::AccessorInfo& info)
 {
     if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
diff -u /mnt/hdd/diff/gen_master/V8HTMLSelectElement.cpp
/mnt/hdd/diff/gen_oc/V8HTMLSelectElement.cpp
--- /mnt/hdd/diff/gen_master/V8HTMLSelectElement.cpp	2013-05-29
11:55:10.086481733 +0900
+++ /mnt/hdd/diff/gen_oc/V8HTMLSelectElement.cpp	2013-05-29 12:45:25.300130338
+0900
@@ -26,6 +26,7 @@
 #include "V8HTMLCollection.h"
 #include "V8HTMLElement.h"
 #include "V8HTMLFormElement.h"
+#include "V8HTMLOptionElement.h"
 #include "V8HTMLOptionsCollection.h"
 #include "V8Node.h"
 #include "V8NodeList.h"
@@ -508,6 +509,19 @@
     return toV8Fast(element.release(), info, collection);
 }
 
+v8::Handle<v8::Value> V8HTMLSelectElement::indexedPropertySetter(uint32_t
index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    HTMLSelectElement* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    RefPtr<HTMLOptionElement> propertyValue =
V8HTMLOptionElement::HasInstance(value, info.GetIsolate(),
worldType(info.GetIsolate())) ?
V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(value)) : 0;
+    bool result = collection->anonymousIndexedSetter(index,
propertyValue.release(), ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 static v8::Persistent<v8::FunctionTemplate>
ConfigureV8HTMLSelectElementTemplate(v8::Persistent<v8::FunctionTemplate> desc,
v8::Isolate* isolate, WrapperWorldType currentWorldType)
 {
     desc->ReadOnlyPrototype();
diff -u /mnt/hdd/diff/gen_master/V8Storage.cpp
/mnt/hdd/diff/gen_oc/V8Storage.cpp
--- /mnt/hdd/diff/gen_master/V8Storage.cpp	2013-05-29 11:55:10.096481811 +0900
+++ /mnt/hdd/diff/gen_oc/V8Storage.cpp	2013-05-29 12:45:25.300130338 +0900
@@ -274,6 +274,19 @@
     return v8String(element, info.GetIsolate());
 }
 
+v8::Handle<v8::Value> V8Storage::indexedPropertySetter(uint32_t index,
v8::Local<v8::Value> value, const v8::AccessorInfo& info)
+{
+    Storage* collection = toNative(info.Holder());
+    ExceptionCode ec = 0;
+    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
+    bool result = collection->anonymousIndexedSetter(index, propertyValue, ec);
+    if (!result)
+        return v8Undefined();
+    if (ec)
+        return setDOMException(ec, info.GetIsolate());
+    return value;
+}
+
 v8::Handle<v8::Boolean> V8Storage::indexedPropertyDeleter(unsigned index, const
v8::AccessorInfo& info)
 {
     Storage* collection = toNative(info.Holder());

[haraken, 2013-05-29 06:41:56]

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3306: }

You should add a $treatUndefinedAs case as well. However, this issue should be
resolved by putting this code into a helper method. See the comment below.

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3310: }

I think we duplicate code of line 3302 - 3310 in CodeGeneratorV8.pm. Can we put
the code in a helper method?

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3326: if (@conditions==1) {

Nit: Spaces needed around '=='.

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3332: $token = "if" if $i==0;

Ditto.

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3333: $token = "else" if
$i==@conditions-1;

Ditto.

https://codereview.chromium.org/15899009/diff/12001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3564: }

We don't want to duplicate the code to build up if-else statements. Can you put
the code into a helper method like GenerateIfElseStatement(@conditions,
@statements)?

https://codereview.chromium.org/15899009/diff/12001/Source/core/html/HTMLOpti...
File Source/core/html/HTMLOptionsCollection.cpp (right):

https://codereview.chromium.org/15899009/diff/12001/Source/core/html/HTMLOpti...
Source/core/html/HTMLOptionsCollection.cpp:131: 

Nit: Unnecessary empty lines.

[kojih, 2013-05-29 08:40:54]

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3504: sub
GenerateNativeVariableDefinitionCorrespondingToJSValueParameter
I think I can simplify some more code using this in the following patch.
I'd like to remove similar method like GetNativeTypeFromSignature.

[haraken, 2013-05-29 08:51:04]

LGTM

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3185: for my $i (0 .. @$conditions-1)
{

Nit: Spaced needed around '-'.

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3188: $token = "else" if $i ==
@$conditions-1;

Ditto.

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3503: #    
"V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);"

Nit: I don't think this comment is needed. (If you want to write it, you can
write it in more detail.)

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3504: sub
GenerateNativeVariableDefinitionCorrespondingToJSValueParameter

Yes, let's do it.

BTW, the method name is too long. GenerateNativeValueDefinition ?

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3506: my $function = shift; #
domFunction

Nit: Remove the comment.

https://codereview.chromium.org/15899009/diff/20001/Source/bindings/scripts/C...
Source/bindings/scripts/CodeGeneratorV8.pm:3507: my $parameterIndex = shift;

You can pass $parameter instead of index.

[commit-bot: I haz the power, 2013-05-29 09:19:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15899009/27001

[commit-bot: I haz the power, 2013-05-29 11:59:12]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-29 12:15:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15899009/27001

[commit-bot: I haz the power, 2013-05-29 14:58:45]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-29 22:25:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15899009/27001

[commit-bot: I haz the power, 2013-05-29 22:25:54]

Failed to apply patch for Source/bindings/tests/results/V8TestEventTarget.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestEventTarget.cpp
  Hunk #1 FAILED at 164.
  Hunk #2 succeeded at 199 (offset -1 lines).
  Hunk #3 FAILED at 212.
  2 out of 3 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestEventTarget.cpp.rej

Patch:       Source/bindings/tests/results/V8TestEventTarget.cpp
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp
b/Source/bindings/tests/results/V8TestEventTarget.cpp
index
b6c85cd3dba329ae1b3e77c1b9e32e1d71c1b6c2..f2fd90bb2d8efeddefd34d07c9ecb40b8c55c4a3
100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -164,7 +164,6 @@ v8::Handle<v8::Value>
V8TestEventTarget::indexedPropertyGetter(uint32_t index, c
 
 v8::Handle<v8::Boolean> V8TestEventTarget::indexedPropertyDeleter(unsigned
index, const v8::AccessorInfo& info)
 {
-
     TestEventTarget* collection = toNative(info.Holder());
     ExceptionCode ec = 0;
     bool result = collection->anonymousIndexedDeleter(index, ec);
@@ -200,7 +199,11 @@ v8::Handle<v8::Value>
V8TestEventTarget::namedPropertySetter(v8::Local<v8::Strin
     TestEventTarget* collection = toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);
     V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyValue, value);
-    bool result = collection->anonymousNamedSetter(propertyName,
propertyValue);
+    bool result;
+    if (value->IsUndefined())
+        result = collection->anonymousNamedSetterUndefined(propertyName);
+    else
+        result = collection->anonymousNamedSetter(propertyName, propertyValue);
     if (!result)
         return v8Undefined();
     return value;
@@ -208,7 +211,6 @@ v8::Handle<v8::Value>
V8TestEventTarget::namedPropertySetter(v8::Local<v8::Strin
 
 v8::Handle<v8::Boolean>
V8TestEventTarget::namedPropertyDeleter(v8::Local<v8::String> name, const
v8::AccessorInfo& info)
 {
-
     TestEventTarget* collection = toNative(info.Holder());
     AtomicString propertyName = toWebCoreAtomicString(name);
     bool result = collection->anonymousNamedDeleter(propertyName);

[commit-bot: I haz the power, 2013-05-30 02:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15899009/44001

[commit-bot: I haz the power, 2013-05-30 05:52:21]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-30 06:35:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15899009/44001

[commit-bot: I haz the power, 2013-05-30 06:36:19]

Change committed as 151449

[Nils Barth (inactive), 2014-01-31 03:03:36]

For reference, the [TreatNullAs=functionName] behavior was removed in:
Replace [TreatNullAs=functionName] with [StrictTypeChecking]
https://codereview.chromium.org/143943020/

This is because the behavior can be specified on the Blink side,
*so long* as type checking is done in the bindings, so a 0 value means
undefined (or null, if nullable), rather than "invalid type":
we can distinguish JS types on the bindings side.

As these CLs demonstrate, specifying "undefined/null = remove, with
removeFunction"
in the bindings bloats the IDL files and the Blink files, due to adding an
auxiliary removeFunction and then having to refer to it.

Also, so far there were only 2 uses of this, so putting this behavior in the
bindings
doesn't save complexity on the Blink side, and makes the CG rather more complex.