Support indexed setter generation

Source/bindings/scripts/CodeGeneratorV8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 3165 matching lines @@
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
 
     my $indexedGetterFunction = GetIndexedGetterFunction($interface);
     my $hasCustomIndexedGetter = $indexedGetterFunction ? $indexedGetterFunction->signature->extendedAttributes->{"Custom"} : 0;
     if ($indexedGetterFunction && !$hasCustomIndexedGetter) {
         GenerateImplementationIndexedPropertyGetter($interface, $indexedGetterFunction);
     }
 
-    # FIXME: Support generated indexed setter bindings.
     my $indexedSetterFunction = GetIndexedSetterFunction($interface);
     my $hasCustomIndexedSetter = $indexedSetterFunction ? $indexedSetterFunction->signature->extendedAttributes->{"Custom"} : 0;
+    if ($indexedSetterFunction && !$hasCustomIndexedSetter) {
+        GenerateImplementationIndexedPropertySetter($interface, $indexedSetterFunction);
+    }
 
     my $indexedDeleterFunction = GetIndexedDeleterFunction($interface);
     my $hasCustomIndexedDeleter = $indexedDeleterFunction ? $indexedDeleterFunction->signature->extendedAttributes->{"Custom"} : 0;
     if ($indexedDeleterFunction && !$hasCustomIndexedDeleter) {
         GenerateImplementationIndexedPropertyDeleter($interface, $indexedDeleterFunction);
     }
 
     # FIXME: Support generated named enumerator bindings.
     my $hasEnumerator = $indexedGetterFunction;
     # FIXME: Remove the special cases. Interfaces that have indexedPropertyGetter should have indexedPropertyEnumerator.
@@ skipping 67 matching lines @@
         $getterCode .= "    return v8Undefined();\n";
     } else {
         $getterCode .= "    if (${isNull})\n";
         $getterCode .= "        return v8Undefined();\n";
         $getterCode .= $returnJSValueCode . "\n";
     }
     $getterCode .= "}\n\n";
     $implementation{nameSpaceWebCore}->add($getterCode);
 }
 
+sub GenerateImplementationIndexedPropertySetter
+{
+    my $interface = shift;
+    my $indexedSetterFunction = shift;
+    my $implClassName = GetImplName($interface);
+    my $v8ClassName = GetV8ClassName($interface);
+    my $methodName = GetImplName($indexedSetterFunction->signature);
+
+    AddToImplIncludes("bindings/v8/V8Collection.h");
+    my $type = $indexedSetterFunction->parameters->[1]->type;
+    my $returnType = $indexedSetterFunction->signature->type;
+    my $nativeType = GetNativeType($returnType);
+    my $nativeValue = JSValueToNative($type, $indexedSetterFunction->signature->extendedAttributes, "value", "info.GetIsolate()");
+    my $raisesExceptions = $indexedSetterFunction->signature->extendedAttributes->{"RaisesException"};
+    my $treatNullAs = $indexedSetterFunction->parameters->[1]->extendedAttributes->{"TreatNullAs"};
+    my $treatUndefinedAs = $indexedSetterFunction->parameters->[1]->extendedAttributes->{"TreatUndefinedAs"};
+    my $code = "v8::Handle<v8::Value> ${v8ClassName}::indexedPropertySetter(uint32_t index, v8::Local<v8::Value> value, const v8::AccessorInfo& info)\n";
+    $code .= "{\n";
+    $code .= "    ${implClassName}* collection = toNative(info.Holder());\n";
+    my $extraArguments = "";
+    if ($raisesExceptions) {
+        $code .= "    ExceptionCode ec = 0;\n";
+        $extraArguments = ", ec";
+    }
+    if ($type eq "DOMString") {
+        my $nullCheck = "";
+        if ($treatNullAs && $treatNullAs eq "NullString") {
+            $nullCheck = "WithNullCheck";
+        }

[haraken, 2013/05/29 06:41:56]

You should add a $treatUndefinedAs case as well. However, this issue should be
resolved by putting this code into a helper method. See the comment below.

+        $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<${nullCheck}>, propertyValue, value);\n";
+    } else {
+        $code .= "    $nativeType propertyValue = $nativeValue;\n";
+    }

[haraken, 2013/05/29 06:41:56]

I think we duplicate code of line 3302 - 3310 in CodeGeneratorV8.pm. Can we put
the code in a helper method?

+    my $passNativeValue = "propertyValue";
+    $passNativeValue .= ".release()" if (IsRefPtrType($type));
+
+    my @conditions = ();
+    my @statements = ();
+    if ($treatNullAs && $treatNullAs ne "NullString") {
+        push @conditions, "value->IsNull()";
+        push @statements, "result = collection->${treatNullAs}(index$extraArguments);";
+    }
+    if ($treatUndefinedAs && $treatUndefinedAs ne "NullString") {
+        push @conditions, "value->IsUndefined()";
+        push @statements, "result = collection->${treatUndefinedAs}(index$extraArguments);";
+    }
+    push @conditions, "";
+    push @statements, "result = collection->${methodName}(index, $passNativeValue$extraArguments);";
+    if (@conditions==1) {

[haraken, 2013/05/29 06:41:56]

Nit: Spaces needed around '=='.

+        $code .= "    bool " . $statements[0] . "\n";
+    } else {
+        $code .= "    bool result;\n";
+        for my $i (0..@conditions-1) {
+            my $token = "else if";
+            $token = "if" if $i==0;

[haraken, 2013/05/29 06:41:56]

Ditto.

+            $token = "else" if $i==@conditions-1;

[haraken, 2013/05/29 06:41:56]

Ditto.

+            $code .= "    ${token}";
+            $code .= " (" . $conditions[$i] . ")" if $conditions[$i];
+            $code .= "\n";
+            $code .= "        " . $statements[$i] . "\n";
+        }
+    }
+
+    $code .= "    if (!result)\n";
+    $code .= "        return v8Undefined();\n";
+    if ($raisesExceptions) {
+        $code .= "    if (ec)\n";
+        $code .= "        return setDOMException(ec, info.GetIsolate());\n";
+    }
+    $code .= "    return value;\n";
+    $code .= "}\n\n";
+    $implementation{nameSpaceWebCore}->add($code);
+}
+
 sub GenerateImplementationNamedPropertyAccessors
 {
     my $interface = shift;
 
     my $interfaceName = $interface->name;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
 
     my $namedGetterFunction = GetNamedGetterFunction($interface);
     my $hasCustomNamedGetter = $namedGetterFunction ? $namedGetterFunction->signature->extendedAttributes->{"Custom"} : 0;
@@ skipping 138 matching lines @@
     my $interface = shift;
     my $namedSetterFunction = shift;
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
     my $methodName = GetImplName($namedSetterFunction->signature);
 
     AddToImplIncludes("bindings/v8/V8Collection.h");
     my $type = $namedSetterFunction->parameters->[1]->type;
     my $nativeType = GetNativeType($type);
     my $raisesExceptions = $namedSetterFunction->signature->extendedAttributes->{"RaisesException"};
+    my $treatNullAs = $namedSetterFunction->parameters->[1]->extendedAttributes->{"TreatNullAs"};
+    my $treatUndefinedAs = $namedSetterFunction->parameters->[1]->extendedAttributes->{"TreatUndefinedAs"};
     my $nativeValue = JSValueToNative($type, $namedSetterFunction->signature->extendedAttributes, "value", "info.GetIsolate()");
 
     my $code = "v8::Handle<v8::Value> ${v8ClassName}::namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)\n";
     $code .= "{\n";
     if (!$namedSetterFunction->signature->extendedAttributes->{"OverrideBuiltins"}) {
         $code .= "    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
         $code .= "        return v8Undefined();\n";
         $code .= "    if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
         $code .= "        return v8Undefined();\n";
     }
     $code .= "    ${implClassName}* collection = toNative(info.Holder());\n";
     $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);\n";
     my $extraArguments = "";
     if ($raisesExceptions) {
         $code .= "    ExceptionCode ec = 0;\n";
         $extraArguments = ", ec";
     }
     if ($type eq "DOMString") {
         my $nullCheck = "";
-        my $treatNullAs = $namedSetterFunction->parameters->[1]->extendedAttributes->{"TreatNullAs"};
         if ($treatNullAs && $treatNullAs eq "NullString") {
             $nullCheck = "WithNullCheck";
         }
         $code .= "    V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<${nullCheck}>, propertyValue, value);\n";
     } else {
         $code .= "    $nativeType propertyValue = $nativeValue;\n";
     }
-    $code .= "    bool result = collection->${methodName}(propertyName, propertyValue$extraArguments);\n";
+
+    my @conditions = ();
+    my @statements = ();
+    if ($treatNullAs && $treatNullAs ne "NullString") {
+        push @conditions, "value->IsNull()";
+        push @statements, "result = collection->${treatNullAs}(propertyName$extraArguments);";
+    }
+    if ($treatUndefinedAs && $treatUndefinedAs ne "NullString") {
+        push @conditions, "value->IsUndefined()";
+        push @statements, "result = collection->${treatUndefinedAs}(propertyName$extraArguments);";
+    }
+    push @conditions, "";
+    push @statements, "result = collection->${methodName}(propertyName, propertyValue$extraArguments);";
+    if (@conditions==1) {
+        $code .= "    bool " . $statements[0] . "\n";
+    } else {
+        $code .= "    bool result;\n";
+        for my $i (0..@conditions-1) {
+            my $token = "else if";
+            $token = "if" if $i==0;
+            $token = "else" if $i==@conditions-1;
+            $code .= "    ${token}";
+            $code .= " (" . $conditions[$i] . ")" if $conditions[$i];
+            $code .= "\n";
+            $code .= "        " . $statements[$i] . "\n";
+        }
+    }

[haraken, 2013/05/29 06:41:56]

We don't want to duplicate the code to build up if-else statements. Can you put
the code into a helper method like GenerateIfElseStatement(@conditions,
@statements)?

+
     $code .= "    if (!result)\n";
     $code .= "        return v8Undefined();\n";
     if ($raisesExceptions) {
         $code .= "    if (ec)\n";
         $code .= "        return setDOMException(ec, info.GetIsolate());\n";
     }
     $code .= "    return value;\n";
     $code .= "}\n\n";
     $implementation{nameSpaceWebCore}->add($code);
 }
@@ skipping 2182 matching lines @@
         if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
             $found = 1;
         }
         return 1 if $found;
     }, 0);
 
     return $found;
 }
 
 1;