Add ability to keep external extension for existing user but don't install it for new users

Add ability to keep external extension for existing user but don't install it for new users

This feature is required to prevent user base expansion without removing extension
for user that use the app. See crbug.com/242806 to see more details.

BUG=242806
TEST=ExtensionServiceTest.ExternalPrefProvider
R=asargent@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203101

[Dmitry Polukhin, 2013-05-29 08:24:51]

Antony, friendly ping, please take a look to this CL.

[asargent_no_longer_on_chrome, 2013-05-29 17:17:27]

lgtm

https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/...
chrome/browser/extensions/external_provider_impl.cc:217: LOG(INFO) << "Skip
installing (or uninstall) external extension: "
Can you use VLOG instead?

http://dev.chromium.org/developers/coding-style#TOC-Logging

[Dmitry Polukhin, 2013-05-29 18:02:40]

https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/...
chrome/browser/extensions/external_provider_impl.cc:217: LOG(INFO) << "Skip
installing (or uninstall) external extension: "
On 2013/05/29 17:17:27, Antony Sargent wrote:
> Can you use VLOG instead?
> 
> http://dev.chromium.org/developers/coding-style#TOC-Logging

Shell I replace LOG(INFO) with VLOG only here or in other similar places in this
function? I see lots of places where LOG(WARNIG/ERROR/INFO) and no one VLOG is
used in this function. For example, supported_locales is exactly the same case
when app is skipped.

[USE_CHROMIUM_ACCT_INSTEAD, 2013-05-29 18:05:00]

In general VLOG is preferred to LOG(INFO), so please replace the others if
you want.




On Wed, May 29, 2013 at 11:02 AM, <dpolukhin@chromium.org> wrote:

>
> https://codereview.chromium.**org/15899007/diff/4006/chrome/**
>
browser/extensions/external_**provider_impl.cc<https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/external_provider_impl.cc>
> File chrome/browser/extensions/**external_provider_impl.cc (right):
>
> https://codereview.chromium.**org/15899007/diff/4006/chrome/**
>
browser/extensions/external_**provider_impl.cc#newcode217<https://codereview.chromium.org/15899007/diff/4006/chrome/browser/extensions/external_provider_impl.cc#newcode217>
> chrome/browser/extensions/**external_provider_impl.cc:217: LOG(INFO) <<
> "Skip installing (or uninstall) external extension: "
> On 2013/05/29 17:17:27, Antony Sargent wrote:
>
>> Can you use VLOG instead?
>>
>
> 
http://dev.chromium.org/**developers/coding-style#TOC-**Logging<http://dev.ch...
>>
>
> Shell I replace LOG(INFO) with VLOG only here or in other similar places
> in this function? I see lots of places where LOG(WARNIG/ERROR/INFO) and
> no one VLOG is used in this function. For example, supported_locales is
> exactly the same case when app is skipped.
>
>
https://codereview.chromium.**org/15899007/<https://codereview.chromium.org/1...
>

[Dmitry Polukhin, 2013-05-30 06:51:13]

Committed patchset #4 manually as r203101 (presubmit successful).