Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 15899007: Add ability to keep external extension for existing user but don't install it for new users (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + s/LOG(INFO)/VLOG(1)/ Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 92a48b636bf186712ce723a9f2e7d6ae402cd418..e947a5fee7caade1dae950101829503589acab40 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -284,6 +284,7 @@ class MockProviderVisitor
: ids_found_(0),
fake_base_path_(fake_base_path),
expected_creation_flags_(Extension::NO_FLAGS) {
+ profile_.reset(new TestingProfile);
}
MockProviderVisitor(base::FilePath fake_base_path,
@@ -298,6 +299,7 @@ class MockProviderVisitor
provider_.reset(new extensions::ExternalProviderImpl(
this,
new extensions::ExternalTestingLoader(json_data, fake_base_path_),
+ profile_.get(),
Manifest::EXTERNAL_PREF,
Manifest::EXTERNAL_PREF_DOWNLOAD,
Extension::NO_FLAGS));
@@ -407,6 +409,7 @@ class MockProviderVisitor
int expected_creation_flags_;
scoped_ptr<extensions::ExternalProviderImpl> provider_;
scoped_ptr<DictionaryValue> prefs_;
+ scoped_ptr<TestingProfile> profile_;
DISALLOW_COPY_AND_ASSIGN(MockProviderVisitor);
};
@@ -4580,6 +4583,19 @@ TEST_F(ExtensionServiceTest, ExternalPrefProvider) {
EXPECT_EQ(2, visitor.Visit(json_data));
}
+ // Test keep_if_present.
+ json_data =
+ "{"
+ " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\": {"
+ " \"external_crx\": \"RandomExtension.crx\","
+ " \"external_version\": \"1.0\","
+ " \"keep_if_present\": true"
+ " }"
+ "}";
+ {
+ EXPECT_EQ(0, visitor.Visit(json_data));
+ }
+
// Test is_bookmark_app.
MockProviderVisitor from_bookmark_visitor(
base_path, Extension::FROM_BOOKMARK);
« no previous file with comments | « chrome/browser/extensions/default_apps.cc ('k') | chrome/browser/extensions/external_policy_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698