Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1589883002: SampleApp: Make android_install_app and android_launch_app work consistently (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, djsollen
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SampleApp: Make android_install_app and android_launch_app work consistently Make android_install_app work more consistently: * App can be "SampleApp" or "VisualBench" Make android_launch_app work more consistently: * Parameters to SampleApp are passed correctly * SampleApp is actually launched The parameters to "am" need to be quoted, since the command is run on the device shell. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1589883002 Committed: https://skia.googlesource.com/skia/+/4c7040bf8a30a191d5c9a3a7286b0ae3ed162611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M platform_tools/android/bin/android_install_app View 3 chunks +8 lines, -5 lines 0 comments Download
M platform_tools/android/bin/android_launch_app View 1 chunk +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-14 11:00:16 UTC) #3
djsollen
lgtm
4 years, 11 months ago (2016-01-14 13:24:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589883002/1
4 years, 11 months ago (2016-01-14 13:56:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589883002/1
4 years, 11 months ago (2016-01-14 14:07:04 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 14:07:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4c7040bf8a30a191d5c9a3a7286b0ae3ed162611

Powered by Google App Engine
This is Rietveld 408576698