patch.py - Issue 15898005: presubmit: Call 'git diff' once per change instead of once per file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: patch.py

Issue 15898005: presubmit: Call 'git diff' once per change instead of once per file (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fix unit test on Windows. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: patch.py

diff --git a/patch.py b/patch.py

index cd594f8e485055a14b0e7963d13c621245301706..9b65ce1cfaed3bc1fbb70551f9cc43346a8f01de 100644

--- a/patch.py

+++ b/patch.py

@@ -318,7 +318,7 @@ class FilePatchDiff(FilePatchBase):

Expects the following format:

- <garbagge>

+ <garbage>

diff --git (|a/)<filename> (|b/)<filename>

« no previous file with comments | « git_cl.py ('k') | presubmit_canned_checks.py » ('j') | presubmit_support.py » ('J')