git_cl.py - Issue 15898005: presubmit: Call 'git diff' once per change instead of once per file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 15898005: presubmit: Call 'git diff' once per change instead of once per file (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fix unit test on Windows. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 082b4ebff80196f73684b3b512a2f09691f1e5ad..728350c50e840a02317c6c1588d151f02267ab5a 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -696,9 +696,9 @@ or verify this branch is set up to track another (via the --track argument to

('\nFailed to diff against upstream branch %s!\n\n'

'This branch probably doesn\'t exist anymore. To reset the\n'

'tracking branch, please run\n'

- ' git branch --set-upstream %s trunk\n'

+ ' git branch --set-upstream-to=trunk\n'

'replacing trunk with origin/master or the relevant branch') %

- (upstream_branch, self.GetBranch()))

+ (upstream_branch))

issue = self.GetIssue()

patchset = self.GetPatchset()

« no previous file with comments | « no previous file | patch.py » ('j') | presubmit_support.py » ('J')