Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1589783004: Merge to XFA: Loose checking for trailer's size field (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Loose checking for trailer's size field Although trailer's size value is required by spec, other readers such as Acrobat or libpoppler can handle without it. Loose up the check to be more tolerant. BUG=pdfium:213 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1582193002 . (cherry picked from commit 34291b900ad0472eef582215cfce0d942a40fd16) Committed: https://pdfium.googlesource.com/pdfium/+/07fb4cf2caa9590402a1c610b9c9d2fb9976f752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 2 chunks +7 lines, -1 line 0 comments Download
A testing/resources/bug_213.pdf View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Wei Li
clean
4 years, 11 months ago (2016-01-14 23:08:24 UTC) #1
Wei Li
clean merge, TBR
4 years, 11 months ago (2016-01-14 23:14:36 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-14 23:14:38 UTC) #3
Wei Li
4 years, 11 months ago (2016-01-14 23:15:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07fb4cf2caa9590402a1c610b9c9d2fb9976f752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698