Loose checking for trailer's size field

Loose checking for trailer's size field

Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.

BUG=pdfium:213
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/34291b900ad0472eef582215cfce0d942a40fd16

[Wei Li, 2016-01-14 03:27:55]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-01-14 03:28:47]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-01-14 03:28:48]

PTAL, thanks

[Wei Li, 2016-01-14 03:31:24]

Forgot to mention, the original file mentioned in the bug is large, and the page
content is irrelevant to the bug. So I used a small example to demo the test
case.

[Lei Zhang, 2016-01-14 19:26:15]

lgtm

https://codereview.chromium.org/1582193002/diff/20001/fpdfsdk/src/fpdfview_em...
File fpdfsdk/src/fpdfview_embeddertest.cpp (right):

https://codereview.chromium.org/1582193002/diff/20001/fpdfsdk/src/fpdfview_em...
fpdfsdk/src/fpdfview_embeddertest.cpp:232: // It tests that document can still
be loaded even the trailer has no 'Size'
Move up to line 206 to keep the bug numbers sorted, and to avoid conflicting
with your other CL.

[Wei Li, 2016-01-14 22:36:56]

Thanks, fixed it. Will submit

https://codereview.chromium.org/1582193002/diff/20001/fpdfsdk/src/fpdfview_em...
File fpdfsdk/src/fpdfview_embeddertest.cpp (right):

https://codereview.chromium.org/1582193002/diff/20001/fpdfsdk/src/fpdfview_em...
fpdfsdk/src/fpdfview_embeddertest.cpp:232: // It tests that document can still
be loaded even the trailer has no 'Size'
On 2016/01/14 19:26:15, Lei Zhang wrote:
> Move up to line 206 to keep the bug numbers sorted, and to avoid conflicting
> with your other CL.

Done.

[Wei Li, 2016-01-14 22:46:12]

Description was changed from

==========
Loose checking for trailer's size field

Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.

BUG=pdfium:213
==========

to

==========
Loose checking for trailer's size field

Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.

BUG=pdfium:213
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/34291b900ad0472eef582215cfce0d942a40...
==========

[Wei Li, 2016-01-14 22:46:13]

Committed patchset #2 (id:40001) manually as
34291b900ad0472eef582215cfce0d942a40fd16 (presubmit successful).