ARM Skia NEON patches - 12 - S32_Blend

ARM Skia NEON patches - 12 - S32_Blend

Blitrow32: S32_Blend fix and little speed improvement

- the results are now exactly similar as the C code
- the speed has improved, especially for small values of count

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | +30%      | +18%       |
+-------+-----------+------------+
| 2     | 0         | 0          |
+-------+-----------+------------+
| 4     | - <1%     | +14%       |
+-------+-----------+------------+
| > 4   | -0.5..+5% | -0.5..+4%  |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>;

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13532

Committed: http://code.google.com/p/skia/source/detail?r=13543

[djsollen, 2014-02-13 17:30:14]

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
File src/opts/SkBlitRow_opts_arm_neon.cpp (right):

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
src/opts/SkBlitRow_opts_arm_neon.cpp:770: if (count > 0) {
instead of nesting the remainder of this method I would turn this into...

if (count <= 0) {
  return;
}

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
src/opts/SkBlitRow_opts_arm_neon.cpp:781: /* The above commented prefetches are
a big win for count
Move this comment to be directly above the prefetch lines.

[kevin.petit, 2014-02-13 17:40:19]

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
File src/opts/SkBlitRow_opts_arm_neon.cpp (right):

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
src/opts/SkBlitRow_opts_arm_neon.cpp:770: if (count > 0) {
On 2014/02/13 17:30:15, djsollen wrote:
> instead of nesting the remainder of this method I would turn this into...
> 
> if (count <= 0) {
>   return;
> }

Done.

https://codereview.chromium.org/158973002/diff/1/src/opts/SkBlitRow_opts_arm_...
src/opts/SkBlitRow_opts_arm_neon.cpp:781: /* The above commented prefetches are
a big win for count
On 2014/02/13 17:30:15, djsollen wrote:
> Move this comment to be directly above the prefetch lines.

Done.

[djsollen, 2014-02-13 17:43:41]

lgtm pending success of trybot runs

[kevin.petit, 2014-02-14 14:33:31]

On 2014/02/13 17:43:41, djsollen wrote:
> lgtm pending success of trybot runs

Could you retrigger the failed bot please? Now that the rebaselines have been
merged the patch will apply.

[kevin.petit, 2014-02-21 15:22:09]

I've just sent a rebased patch. Do you want to launch the bots or are you happy
for me to commit it?

[djsollen, 2014-02-21 15:25:58]

lgtm, so feel free to submit after you address my one nit.

https://codereview.chromium.org/158973002/diff/170001/expectations/gm/ignored...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/158973002/diff/170001/expectations/gm/ignored...
expectations/gm/ignored-tests.txt:63: # Added by kevin.petit.arm@gmail.com for
https://codereview.chromium.org/18173012/
nit, but can you update your email?

[kevin.petit, 2014-02-21 15:29:33]

https://codereview.chromium.org/158973002/diff/170001/expectations/gm/ignored...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/158973002/diff/170001/expectations/gm/ignored...
expectations/gm/ignored-tests.txt:63: # Added by kevin.petit.arm@gmail.com for
https://codereview.chromium.org/18173012/
On 2014/02/21 15:25:59, djsollen wrote:
> nit, but can you update your email?

Done.

[kevin.petit, 2014-02-21 15:29:44]

The CQ bit was checked by kevin.petit@arm.com

[commit-bot: I haz the power, 2014-02-21 15:29:48]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/158973002/240001

[commit-bot: I haz the power, 2014-02-21 17:40:40]

Change committed as 13532

[scroggo, 2014-02-21 17:52:08]

A revert of this CL has been created in
https://codereview.chromium.org/175433002/ by scroggo@google.com.

The reason for reverting is: Breaking the build.

See
http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-Nexus4/bu...
(and others).

We are getting warnings that vsrc and vdst may be uninitialized. Please fix and
resubmit..

[kevin.petit, 2014-02-21 18:12:08]

On 2014/02/21 17:52:08, scroggo wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/175433002/ by mailto:scroggo@google.com.
> 
> The reason for reverting is: Breaking the build.
> 
> See
>
http://108.170.219.164:10117/builders/Build-Ubuntu12-GCC-Arm7-Debug-Nexus4/bu...
> (and others).
> 
> We are getting warnings that vsrc and vdst may be uninitialized. Please fix
and
> resubmit..

Sorry for that, committing the fixed version.

[kevin.petit, 2014-02-21 18:12:13]

The CQ bit was checked by kevin.petit@arm.com

[commit-bot: I haz the power, 2014-02-21 18:12:22]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/158973002/350001

[commit-bot: I haz the power, 2014-02-21 18:23:30]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/158973002/350001

[commit-bot: I haz the power, 2014-02-21 18:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 18:23:32]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -p1;
  Created missing directory expectations/gm.
  error: expectations/gm/ignored-tests.txt: does not exist in index

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
2ad81f08823fa399aca5a77c89ef5c6b4373e05d..28321d01eda50682237144dacca256016d0007d7
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -59,3 +59,11 @@ imagefiltersscaled
 
 # Added by yunchao.he@intel.com for https://codereview.chromium.org/166023002
 inverse_paths
+
+# Added by kevin.petit@arm.com for https://codereview.chromium.org/158973002
+roundrects
+gradients_view_perspective
+filltypespersp
+bleed
+bitmaprect_i
+bitmaprect_s

[kevin.petit, 2014-02-21 18:30:34]

The CQ bit was checked by kevin.petit@arm.com

[commit-bot: I haz the power, 2014-02-21 18:30:38]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/158973002/200002

[commit-bot: I haz the power, 2014-02-21 19:13:05]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/kevin.petit@arm.com/158973002/200002

[commit-bot: I haz the power, 2014-02-21 19:49:19]

Change committed as 13543