third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp - Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1589703002: Surface SCT (Signed Certificate Timestamp) counts in the Security panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address latest comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/sct-summary-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('j') | third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

index 732cf7ff99f8b422a35bfd72d6fadb7655218e71..498cbd5e4e5c6efb55a76821f38b52711b938ef1 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

@@ -383,11 +383,21 @@ static PassRefPtr<TypeBuilder::Network::Response> buildObjectForResourceResponse

const ResourceResponse::SecurityDetails* responseSecurityDetails = response.securityDetails();

+ int numUnknownSCTs = safeCast<int>(responseSecurityDetails->numUnknownSCTs);

+ int numInvalidSCTs = safeCast<int>(responseSecurityDetails->numInvalidSCTs);

+ int numValidSCTs = safeCast<int>(responseSecurityDetails->numValidSCTs);

+ RefPtr<TypeBuilder::Network::CertificateValidationDetails> certificateValidationDetails = TypeBuilder::Network::CertificateValidationDetails::create()

+ .setNumUnknownScts(numUnknownSCTs)

+ .setNumInvalidScts(numInvalidSCTs)

+ .setNumValidScts(numValidSCTs);

RefPtr<TypeBuilder::Network::SecurityDetails> securityDetails = TypeBuilder::Network::SecurityDetails::create()

.setProtocol(responseSecurityDetails->protocol)

.setKeyExchange(responseSecurityDetails->keyExchange)

.setCipher(responseSecurityDetails->cipher)

.setCertificateId(responseSecurityDetails->certID);

+ securityDetails->setCertificateValidationDetails(certificateValidationDetails);

if (responseSecurityDetails->mac.length() > 0)

securityDetails->setMac(responseSecurityDetails->mac);