runtime/vm/ast.h - Issue 1589643002: Source positions for constructors and lots of async machinery

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast.h

Issue 1589643002: Source positions for constructors and lots of async machinery (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/ast.h

diff --git a/runtime/vm/ast.h b/runtime/vm/ast.h

index 01ae0cf1544a072769676c3d7e6b402ea7186033..d1e62c9326508ef56679e930195fa0ae2f86dd6f 100644

--- a/runtime/vm/ast.h

+++ b/runtime/vm/ast.h

@@ -99,7 +99,8 @@ class AstNode : public ZoneAllocated {

public:

explicit AstNode(intptr_t token_pos)

: token_pos_(token_pos) {

- ASSERT(Scanner::ValidSourcePosition(token_pos_));

+ ASSERT(!Token::IsClassifying(token_pos_) ||

+ (token_pos_ == ClassifyingTokenPositions::kMethodExtractor));

}

virtual ~AstNode() { }

« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/ast_printer_test.cc » ('j') | no next file with comments »