Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1589643002: Source positions for constructors and lots of async machinery (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/coverage_test.dart ('k') | runtime/vm/ast.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 58de4e660f99ff402c5d1a2dd1bc5573690a900f..01704152c16bfe6876f5c001ef0023cf60956dce 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -255,9 +255,11 @@ IsolateTest stoppedAtLine(int line) {
Frame top = frames[0];
Script script = await top.location.script.load();
- if (script.tokenToLine(top.location.tokenPos) != line) {
+ int actualLine = script.tokenToLine(top.location.tokenPos);
+ if (actualLine != line) {
var sb = new StringBuffer();
- sb.write("Expected to be at line $line, but got stack trace:\n");
+ sb.write("Expected to be at line $line but actually at line $actualLine");
+ sb.write("\nFull stack trace:\n");
for (Frame f in stack['frames']) {
sb.write(" $f\n");
}
« no previous file with comments | « runtime/observatory/tests/service/coverage_test.dart ('k') | runtime/vm/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698