Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1589633005: Revert of these _procs_arm are not used when we have NEON (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
Reviewers:
msarett, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of these _procs_arm are not used when we have NEON (patchset #1 id:1 of https://codereview.chromium.org/1587983004/ ) Reason for revert: Breaks Chrome roll: https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/8391/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > these _procs_arm are not used when we have NEON > > BUG=skia:4798 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1587983004 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/349dcc99b69f27ab834232796371e678625078e0 TBR=msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4798 Committed: https://skia.googlesource.com/skia/+/c55f699e8b01644b49dddfc21bfb538f1a5ed06a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/opts/SkBlitRow_opts_arm.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of these _procs_arm are not used when we have NEON
4 years, 11 months ago (2016-01-14 21:49:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589633005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589633005/1
4 years, 11 months ago (2016-01-14 21:49:11 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 21:49:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c55f699e8b01644b49dddfc21bfb538f1a5ed06a

Powered by Google App Engine
This is Rietveld 408576698