Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 158953002: Spoken feedback sounds for user photo capture/discard at image picker added. (Closed)

Created:
6 years, 10 months ago by merkulova
Modified:
6 years, 10 months ago
Reviewers:
Nikita (slow), jam, jennyz
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Spoken feedback sounds for user photo capture/discard at image picker screen added. Also added accessibility message for flip-state announce. Image-picker available on oobe flow, in chrome://settings change-picture option, supervised user creation. For in-settings screen default images titles added for spoken feedback. Small css fixes: Tabbing to flip-photo button restricted for non-camera images. Image frame for camera-flow case set same as for stable images. BUG=166651, 155196, 343065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253494

Patch Set 1 #

Patch Set 2 : Propagated to oobe and supervised creation screens. Default images titles now pronounced. #

Patch Set 3 : Flip-photo accessibility messages added to all 3 screens. #

Total comments: 5

Patch Set 4 : Nits #

Patch Set 5 : PlaySystemSound... functions introduced according to latest changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -30 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.css View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.html View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 2 3 4 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.css View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_locally_managed_user_creation.js View 1 2 3 3 chunks +35 lines, -4 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/camera_snap.wav View Binary file 0 comments Download
A chrome/browser/resources/chromeos/sounds/object_delete.wav View Binary file 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.html View 1 2 3 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.js View 1 2 3 7 chunks +53 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/locally_managed_user_creation_screen_handler.cc View 1 2 3 4 6 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 2 3 4 5 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 8 chunks +37 lines, -0 lines 0 comments Download
M chromeos/audio/chromeos_sounds.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
merkulova
6 years, 10 months ago (2014-02-10 14:29:41 UTC) #1
Nikita (slow)
lgtm
6 years, 10 months ago (2014-02-11 12:32:02 UTC) #2
jennyz
lgtm
6 years, 10 months ago (2014-02-12 00:16:41 UTC) #3
merkulova
Propagated to other than settings screens.
6 years, 10 months ago (2014-02-12 10:20:03 UTC) #4
merkulova
Propagated to all 3 screens (yes, we need refactoring). Flip-button sounds added.
6 years, 10 months ago (2014-02-14 09:58:32 UTC) #5
Nikita (slow)
slgtm with nits https://codereview.chromium.org/158953002/diff/140001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html File chrome/browser/resources/chromeos/login/oobe_screen_user_image.html (right): https://codereview.chromium.org/158953002/diff/140001/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html#newcode23 chrome/browser/resources/chromeos/login/oobe_screen_user_image.html:23: tabindex="2"></button> nit: 4 spaces indent here ...
6 years, 10 months ago (2014-02-14 11:13:29 UTC) #6
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 10 months ago (2014-02-14 11:26:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/158953002/350001
6 years, 10 months ago (2014-02-14 11:26:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 11:45:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50315
6 years, 10 months ago (2014-02-14 11:45:59 UTC) #10
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 10 months ago (2014-02-18 20:09:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/158953002/350001
6 years, 10 months ago (2014-02-18 20:11:26 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 20:32:14 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50761
6 years, 10 months ago (2014-02-18 20:32:14 UTC) #14
Nikita (slow)
+jam@ for OWNERS review of chrome/browser/browser_resources.grd
6 years, 10 months ago (2014-02-19 10:54:12 UTC) #15
jam
On 2014/02/19 10:54:12, Nikita Kostylev wrote: > +jam@ for OWNERS review of > chrome/browser/browser_resources.grd lgtm
6 years, 10 months ago (2014-02-25 18:10:18 UTC) #16
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 10 months ago (2014-02-26 06:48:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/158953002/350001
6 years, 10 months ago (2014-02-26 06:48:50 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 10:17:39 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-26 10:17:40 UTC) #20
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 10 months ago (2014-02-26 10:51:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/158953002/820001
6 years, 10 months ago (2014-02-26 10:51:51 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 17:29:03 UTC) #23
Message was sent while issue was closed. 
Change committed as 253494

Powered by Google App Engine
This is Rietveld 408576698