Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/resources/options/chromeos/change_picture_options.html

Issue 158953002: Spoken feedback sounds for user photo capture/discard at image picker added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: PlaySystemSound... functions introduced according to latest changes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/change_picture_options.html
diff --git a/chrome/browser/resources/options/chromeos/change_picture_options.html b/chrome/browser/resources/options/chromeos/change_picture_options.html
index 571555750dfb78eb4181fda76cb2b17864567abd..146585dc904678bf6f878dc24f71ca02f04ab67c 100644
--- a/chrome/browser/resources/options/chromeos/change_picture_options.html
+++ b/chrome/browser/resources/options/chromeos/change_picture_options.html
@@ -4,7 +4,7 @@
<div class="content-area">
<div i18n-content="changePicturePageDescription"></div>
<div id="user-images-area">
- <grid id="user-image-grid" class="user-image-picker"></grid>
+ <grid id="user-image-grid" class="user-image-picker" tabindex="1"></grid>
<div id="user-image-preview">
<img id="user-image-preview-img" i18n-values="alt:previewAltText">
<div class="user-image-stream-area">
@@ -15,9 +15,12 @@
</div>
<div class="spinner"></div>
</div>
- <button id="flip-photo" class="custom-appearance"></button>
- <button id="discard-photo"></button>
- <button id="take-photo"></button>
+ <button id="discard-photo" i18n-values="title:discardPhoto"
+ tabindex="2"></button>
+ <button id="take-photo" i18n-values="title:takePhoto" tabindex="2">
+ </button>
+ <button id="flip-photo" class="custom-appearance"
+ i18n-values="title:flipPhoto" tabindex="1"></button>
</div>
</div>
<div id="user-image-attribution">
@@ -28,7 +31,8 @@
</div>
<div class="action-area">
<div class="button-strip">
- <button id="change-picture-overlay-confirm" i18n-content="done"></button>
+ <button id="change-picture-overlay-confirm" i18n-content="done"
+ tabindex="2"></button>
</div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698