Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 15893002: Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the sh… (Closed)

Created:
7 years, 7 months ago by reed1
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, mitica
Visibility:
Public.

Description

Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the shared parameters for all gradients into a struct. BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=9273

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -85 lines) Patch
A gm/alphagradients.cpp View 1 chunk +82 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkShader.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkGradientShader.h View 1 2 3 4 8 chunks +31 lines, -19 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 3 4 5 6 7 18 chunks +129 lines, -60 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
have not yet plumbed it into radial, etc. just wanted to first review - actual ...
7 years, 7 months ago (2013-05-23 15:41:48 UTC) #1
bsalomon
On 2013/05/23 15:41:48, reed1 wrote: > have not yet plumbed it into radial, etc. just ...
7 years, 7 months ago (2013-05-23 17:29:46 UTC) #2
reed1
may leave in Descriptor, but just for looks for now
7 years, 7 months ago (2013-05-23 17:43:29 UTC) #3
reed1
PTAL
7 years, 7 months ago (2013-05-23 17:49:22 UTC) #4
bsalomon
On 2013/05/23 17:49:22, reed1 wrote: > PTAL lgtm
7 years, 7 months ago (2013-05-23 17:50:55 UTC) #5
reed1
7 years, 7 months ago (2013-05-23 17:58:59 UTC) #6
reed1
all of our gms draw wacky when run in release mode :( . at least ...
7 years, 7 months ago (2013-05-23 21:30:59 UTC) #7
reed1
patch #7 fixes release mode PTAL
7 years, 7 months ago (2013-05-23 21:37:16 UTC) #8
bsalomon
On 2013/05/23 21:37:16, reed1 wrote: > patch #7 fixes release mode > PTAL lgtm (ugh)
7 years, 7 months ago (2013-05-24 12:30:19 UTC) #9
reed1
7 years, 7 months ago (2013-05-24 14:58:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #8 manually as r9273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698