[Contextual Search] Enable for fullscreen

chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java
index da3742d08f0f94ff80632d7ca4eb8d28b8f20395..a21150ce97e954742b412f3caca6f1d48ed77816 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/ContextualSearchLayout.java
@@ -78,13 +78,14 @@ public class ContextualSearchLayout extends ContextualSearchSupportedLayout {
      * @param width  The new width in dp.
      * @param height The new height in dp.
      */
+    @Override

[Theresa, 2016/01/14 20:26:02]

Note: this annotation was missing; this method overrides onSizeChanged in
ContextualSearchSupportedLayout.

[Donn Denman, 2016/01/14 20:44:34]

Acknowledged.

     protected void onSizeChanged(float width, float height) {
         if (mBaseTab != null) {
             OverlayPanel panel = mPanelManager.getActivePanel();
             if (panel != null) {
                 mBaseTab.setMaxContentWidth(width);
-                mBaseTab.setMaxContentHeight(panel.getMaximumHeight());
-                mBaseTab.setContentSize(width, panel.getMaximumHeight());
+                mBaseTab.setMaxContentHeight(panel.getFullscreenHeight());

[Theresa, 2016/01/14 20:26:02]

Without this change I was seeing a bug in narrow panel mode when the tab was in
fullscreen where the base tab contents didn't draw to the bottom of the screen.
In narrow panel mode, when this call is made ContextualSearchPanelBase's
mMaximumHeight = getFullScreenHeight() - mToolbarHeight. For the regular panel,
when this call is made mMaximumHeight = getFullScreenHeight(). See
ContextualSearchPanelBase#getPanelHeightFromState(PanelState.MAXIMIZED). The
narrow panel's max height is shorter than the regular (fullscreen) panel's max
height, which results in the tab contents height being shorter.


I think changing these two lines of code makes sense, but I don't know if
there's any special history about why getMaximumHeight() was chosen initially.
This method was introduced in https://codereview.chromium.org/1536623003/

If any of the reviewers who are in town remember the original change/history,
please let me know. Otherwise I will discuss with Pedro when he returns (there's
no rush to get this CL landed).

+                mBaseTab.setContentSize(width, panel.getFullscreenHeight());
             }
         }
     }