Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 1589023003: [Contextual Search] Enable for fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move a couple of methods Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index 9a865e42e9bae89cf7c3d489cbb6905c223f6eda..f658b89aba4d234a4fa202c2c1471c1102292a17 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -1103,7 +1103,7 @@ public class ContextualSearchManager extends ContextualSearchObservable
@Override
public void onSelectionChanged(String selection) {
// Workaround to disable Contextual Search in HTML fullscreen mode. crbug.com/511977
Changwan Ryu 2016/01/15 01:17:10 remove this comment. By the way, why do you still
Theresa 2016/01/15 01:37:24 We don't want to Contextual Search to work in full
Theresa 2016/01/16 01:15:34 Done.
- if (!mActivity.getFullscreenManager().getPersistentFullscreenMode()) {
+ if (!mActivity.getFullscreenManager().isOverlayVideoMode()) {
mSelectionController.handleSelectionChanged(selection);
mSearchPanel.updateTopControlsState(TopControlsState.BOTH, true);
}
@@ -1111,7 +1111,7 @@ public class ContextualSearchManager extends ContextualSearchObservable
@Override
public void onSelectionEvent(int eventType, float posXPix, float posYPix) {
- if (!mActivity.getFullscreenManager().getPersistentFullscreenMode()) {
+ if (!mActivity.getFullscreenManager().isOverlayVideoMode()) {
mSelectionController.handleSelectionEvent(eventType, posXPix, posYPix);
}
}
@@ -1119,7 +1119,7 @@ public class ContextualSearchManager extends ContextualSearchObservable
@Override
public void showUnhandledTapUIIfNeeded(final int x, final int y) {
mDidBasePageLoadJustStart = false;
- if (!mActivity.getFullscreenManager().getPersistentFullscreenMode()) {
+ if (!mActivity.getFullscreenManager().isOverlayVideoMode()) {
mSelectionController.handleShowUnhandledTapUIIfNeeded(x, y);
}
}

Powered by Google App Engine
This is Rietveld 408576698