Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
index ee043be0c9bf62eebd295cb999d37db13d95ebcc..0125235469e137adfcd257e8ac2fbecad4bfd9c4 100644
--- a/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp
@@ -116,11 +116,11 @@ void SVGAngleTearOff::setValueAsString(const String& value, ExceptionState& exce
SVGParsingError status = target()->setValueAsString(value);
- if (status == NoError && !hasExposedAngleUnit()) {
+ if (status == SVGParseStatus::NoError && !hasExposedAngleUnit()) {
target()->setValueAsString(oldValue); // rollback to old value
- status = ParsingAttributeFailedError;
+ status = SVGParseStatus::ParsingFailed;
}
- if (status != NoError) {
+ if (status != SVGParseStatus::NoError) {
exceptionState.throwDOMException(SyntaxError, "The value provided ('" + value + "') is invalid.");
return;
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAngle.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698