Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAngle.cpp

Issue 1588993005: Extended error reporting for SVG attribute parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add PLATFORM_EXPORT Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAngle.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAngle.cpp b/third_party/WebKit/Source/core/svg/SVGAngle.cpp
index 282f645e30d21f1d346803c9784b34e2b8449d21..8cfd6e50d41fe02ad712a3408c2d040f905dbd6c 100644
--- a/third_party/WebKit/Source/core/svg/SVGAngle.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAngle.cpp
@@ -237,18 +237,18 @@ SVGParsingError SVGAngle::setValueAsString(const String& value)
{
if (value.isEmpty()) {
newValueSpecifiedUnits(SVG_ANGLETYPE_UNSPECIFIED, 0);
- return NoError;
+ return SVGParseStatus::NoError;
}
if (value == "auto") {
newValueSpecifiedUnits(SVG_ANGLETYPE_UNSPECIFIED, 0);
m_orientType->setEnumValue(SVGMarkerOrientAuto);
- return NoError;
+ return SVGParseStatus::NoError;
}
if (value == "auto-start-reverse") {
newValueSpecifiedUnits(SVG_ANGLETYPE_UNSPECIFIED, 0);
m_orientType->setEnumValue(SVGMarkerOrientAutoStartReverse);
- return NoError;
+ return SVGParseStatus::NoError;
}
float valueInSpecifiedUnits = 0;
@@ -257,12 +257,12 @@ SVGParsingError SVGAngle::setValueAsString(const String& value)
bool success = value.is8Bit() ? parseValue<LChar>(value, valueInSpecifiedUnits, unitType)
: parseValue<UChar>(value, valueInSpecifiedUnits, unitType);
if (!success)
- return ParsingAttributeFailedError;
+ return SVGParseStatus::ParsingFailed;
m_orientType->setEnumValue(SVGMarkerOrientAngle);
m_unitType = unitType;
m_valueInSpecifiedUnits = valueInSpecifiedUnits;
- return NoError;
+ return SVGParseStatus::NoError;
}
void SVGAngle::newValueSpecifiedUnits(SVGAngleType unitType, float valueInSpecifiedUnits)
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698