Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1588913002: Fix AccountInfo uninitialized memory issues. (Closed)

Created:
4 years, 11 months ago by bzanotti
Modified:
4 years, 11 months ago
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AccountInfo uninitialized memory issues. AccountInfo constructor now correctly initializes all its members. Re-enable the affected tests under MSan. BUG=577333 Committed: https://crrev.com/731c9854a077abbfb801f9e6e53687ca25798d95 Cr-Commit-Position: refs/heads/master@{#369419}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicit default value to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M components/signin/core/browser/account_info.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M components/signin/core/browser/account_info_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M components/signin/core/browser/account_tracker_service_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bzanotti
Please take a look.
4 years, 11 months ago (2016-01-14 13:02:37 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/1588913002/diff/1/components/signin/core/browser/account_info.cc File components/signin/core/browser/account_info.cc (right): https://codereview.chromium.org/1588913002/diff/1/components/signin/core/browser/account_info.cc#newcode33 components/signin/core/browser/account_info.cc:33: is_child_account() {} nit: could you explicitly set the ...
4 years, 11 months ago (2016-01-14 14:40:08 UTC) #3
bzanotti
https://codereview.chromium.org/1588913002/diff/1/components/signin/core/browser/account_info.cc File components/signin/core/browser/account_info.cc (right): https://codereview.chromium.org/1588913002/diff/1/components/signin/core/browser/account_info.cc#newcode33 components/signin/core/browser/account_info.cc:33: is_child_account() {} On 2016/01/14 14:40:08, Roger Tawa wrote: > ...
4 years, 11 months ago (2016-01-14 14:42:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588913002/20001
4 years, 11 months ago (2016-01-14 14:42:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 15:35:40 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 15:36:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/731c9854a077abbfb801f9e6e53687ca25798d95
Cr-Commit-Position: refs/heads/master@{#369419}

Powered by Google App Engine
This is Rietveld 408576698